Closed Bug 1437881 Opened 2 years ago Closed Last year

Add telemetry for the 3 pane inspector

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Add telemetry for the 3 pane inspector based on the success metrics in https://docs.google.com/document/d/1FDhZp-Qd9u38l14t8eU-hPG54Na7GqbBDFQWraNIyws/edit#heading=h.4gbd08flsik8
Assignee: nobody → gl
Status: NEW → ASSIGNED
Comment on attachment 8968318 [details]
Bug 1437881 - Add telemetry for the 3 pane inspector.

https://reviewboard.mozilla.org/r/236994/#review243132

Looks good code wise, thanks Gabriel. Some comments on the Scalars part, but you will need to ask for data-review anyway:
- copy https://github.com/mozilla/data-review/blob/master/request.md and provide all requested info
- ping a data-peer (list at https://wiki.mozilla.org/Firefox/Data_Collection )

::: toolkit/components/telemetry/Scalars.yaml:887
(Diff revision 1)
> +devtools.inspector:
> +  three_pane_enabled:
> +    bug_numbers:
> +      - 1437881
> +    description: >
> +      Number of times the DevTools inspector was opened with the 3 pane inspector enabled.

Maybe we should describe that the keys are true/false

::: toolkit/components/telemetry/Scalars.yaml:888
(Diff revision 1)
> +  three_pane_enabled:
> +    bug_numbers:
> +      - 1437881
> +    description: >
> +      Number of times the DevTools inspector was opened with the 3 pane inspector enabled.
> +    expires: never

new probes should have a set expiry date (eg 65) at which point they can be reviewed and we can decide if they should never expire.

::: toolkit/components/telemetry/Scalars.yaml:892
(Diff revision 1)
> +      Number of times the DevTools inspector was opened with the 3 pane inspector enabled.
> +    expires: never
> +    kind: uint
> +    keyed: true
> +    notification_emails:
> +      - dev-developer-tools@lists.mozilla.org

needs a second line with your own email
Attachment #8968318 - Flags: review?(jdescottes) → review+
Attached file data-review.txt
Attachment #8970065 - Flags: review?(francois)
Comment on attachment 8970065 [details]
data-review.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Scalars.yaml.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Not permanent.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 2.

5) Is the data collection request for default-on or default-off?

Default on.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, telemetry alerts are enough.
Attachment #8970065 - Flags: review?(francois) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb7f6ce7dff5
Add telemetry for the 3 pane inspector. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/cb7f6ce7dff5
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.