1437886 - Crash in mozilla::wr::RenderThread::RegisterExternalImage

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-bda472fd-03c5-4f49-8507-d89a80180213.
=============================================================

Top 10 frames of crashing thread:

0 libc.so libc.so@0x47f4e 
1 libxul.so mozilla::wr::RenderThread::RegisterExternalImage xpcom/threads/Mutex.h:65
2 libxul.so mozilla::detail::RunnableFunction<>::Run gfx/layers/ipc/SharedSurfacesParent.cpp:125
3 libxul.so nsTHashtable<nsBaseHashtableET<nsUint64HashKey, RefPtr<mozilla::gfx::SourceSurfaceSharedDataWrapper> > >::s_InitEntry xpcom/ds/nsTHashtable.h:474
4 libxul.so MessageLoop::RunTask ipc/chromium/src/base/message_loop.cc:452
5 libxul.so MessageLoop::DeferOrRunPendingTask ipc/chromium/src/base/message_loop.cc:460
6 libxul.so MessageLoop::DoWork ipc/chromium/src/base/message_loop.cc:535
7 libxul.so base::MessagePumpDefault::Run ipc/chromium/src/base/message_pump_default.cc:36
8 libxul.so base::MessagePumpDefault::MessagePumpDefault ipc/chromium/src/base/message_pump_default.cc
9 libxul.so std::__ndk1::__vector_base<MessageLoop::PendingTask, std::__ndk1::allocator<MessageLoop::PendingTask> >::__destruct_at_end xpcom/base/nsCOMPtr.h:313

=============================================================

There 33 crashes from 8 installations in nightly 60 starting with buildid 20180213100129.
It could be a consequence of patch for bug 1432375.
:aosmond, could you investigate please ?

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

It looks like image.mem.shared is enabled, while WebRender is disabled. That isn't a supported combination. I need to make sure nothing went wrong with the override pref though.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

It may be possible that it refused to enable WebRender, but since gfx.webrender.all was set, image.mem.shared was also set. I may need to check gfxVars::UseWebRender as well.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Attachment: 0001-Bug-1437886-Prevent-shared-surfaces-from-being-used-.patch, v1

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fed91606dc532a5e11bf82385006d47bfff0b046

Comment 6

[Marcia Knous [:marcia]]

Adding a few desktop signatures, Windows and Mac.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ffed9c081fa
Prevent shared surfaces from being used without WebRender. r=nical

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cff37914d625
Backed out changeset 2ffed9c081fa for test bustage on a CLOSED TREE. r=backout

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

Attachment: 0001-Bug-1437886-Prevent-shared-surfaces-from-being-used-.patch, v2 [carries r=nical]

Very annoying. I can't trust gfxVars will be initialized on all code paths. As an alternative, I added a gfxVars var alternative method GetXXXOrDefault, which will return the default if it isn't initialized. For the purposes of checking if WebRender is enabled or not, this is fine in imagelib, even if we get it wrong at the beginning (we lose some optimizations at worst). No evidence this happens in normal builds though.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=88c97ec9bbf45d8d31dbb7c80fe587c80702f7d4

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa3b9f40e77b
Prevent shared surfaces from being used without WebRender. r=nical

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/fa3b9f40e77b

Comment 12

[Nicholas Nethercote [inactive]]

This is present in Nightly 20180216104033, but not present in the subsequent Nightly builds that have the fix. Thanks!