1437891 - Enable readability-redundant-string-cstr & readability-redundant-string-init checkers

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-string-init.html
    2 occurrences, one thirdparty (valve), one in our code.
https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-string-cstr.html
    6 occurrences in our code base, only in thirdparty code (angle & valve code)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1437891 - Enable readability-redundant-string-cstr & readability-redundant-string-init checkers

Review commit: https://reviewboard.mozilla.org/r/219870/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219870/

Comment 2

[Andi [:andi]]

Comment on attachment 8950597 [details]
Bug 1437891 - Enable readability-redundant-string-cstr & readability-redundant-string-init checkers

https://reviewboard.mozilla.org/r/219870/#review226416

These two ones are very interesting.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/407ae28b996c
Enable readability-redundant-string-cstr & readability-redundant-string-init checkers r=andi

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/407ae28b996c