Closed
Bug 1437891
Opened 6 years ago
Closed 6 years ago
Enable readability-redundant-string-cstr & readability-redundant-string-init checkers
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-string-init.html 2 occurrences, one thirdparty (valve), one in our code. https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-string-cstr.html 6 occurrences in our code base, only in thirdparty code (angle & valve code)
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8950597 [details] Bug 1437891 - Enable readability-redundant-string-cstr & readability-redundant-string-init checkers https://reviewboard.mozilla.org/r/219870/#review226416 These two ones are very interesting.
Attachment #8950597 -
Flags: review?(bpostelnicu) → review+
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/407ae28b996c Enable readability-redundant-string-cstr & readability-redundant-string-init checkers r=andi
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/407ae28b996c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•