Closed Bug 1438001 Opened 4 years ago Closed 3 years ago

Replace use of flatpickr date picker with native date inputs

Categories

(Socorro :: General, task, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wsmwk, Assigned: willkg)

References

Details

Attachments

(2 files)

Using time shortcuts for From and To, I cannot query to the most recent minutes.  It shows "to 5 hours ago."which is equivalent to my timezone offset.
 
- https://crash-stats.mozilla.com/topcrashers/?product=Thunderbird&version=59.0b1
- click first crash signature
- it gives results to very recent minutes (say 5-35 minutes)
- click show filters
- click a time shortcut, like 14 days. 
- click search

results: if time was 15:21 (which is correct local time), the search results show time of 10:21 (a differents of 5 hours) equal to my timezone. If it is really searching to 10:21 EST then no results shown for the last 5 hours.

Certain other sequences of arriving at a query and clicking a shortcut do NOT exhibit this problem.
The search URL with the incorrect results shows <2018-02-13T15%3A46%3A00.000Z

Note 15:46 is my LOCAL time, not zulu
Adrian do you know whether this is a permanent limitation?
Flags: needinfo?(adrian)
Summary: super search time "shortcut" adjusts by timezone → super search time "shortcut" From and To are incorrectly adjusted by timezone, cutting off most recent results
I think it's an issue with the ui. I don't think the API has this problem.

If it helps, I usually put the "To" a day in the future.
Flags: needinfo?(adrian)
Whiteboard: [good first bug]
Assignee: nobody → is2ei.horie
Attached file GitHub pull request
Hi Will,
I attached PR link. Could you please review it?
Attachment #8979085 - Flags: review?(willkg)
Comment on attachment 8979085 [details] [review]
GitHub pull request

Removing me as reviewer. We track code review and status in GitHub and Mike is reviewing this there already.
Attachment #8979085 - Flags: review?(willkg)
I closed the PR since Flatpickr does not support UTC now.
Re-scoping this bug to be about replacing Flatpickr, since it doesn't support UTC in a way that works with our requirements, mainly:

- All displayed dates should be in UTC.
- All dates sent to the server should be in UTC
- Clicking the shortcut links should fill the date pickers with UTC times
- The "Showing results from 3 minutes ago to now" text should be relative to the user's local time, even if the dates we're working with are UTC (otherwise, it says things like "7 hours ago" instead of "now" due to timezone offsets).

There's good browser support for date and time pickers now, so we should be using those instead.
Assignee: is2ei.horie → nobody
Summary: super search time "shortcut" From and To are incorrectly adjusted by timezone, cutting off most recent results → Replace use of flatpickr date picker with native date inputs
Whiteboard: [good first bug]
Priority: -- → P3
Hi Michael,

Could I continue to work on this issue?
Flags: needinfo?(mkelly)
is2ei: Thank you for the offer, but we haven't yet decided the design we want to use with the new date and time pickers, which is why I removed the "good first bug" label. I'd like to wait until we have something like that before we start work on this again.
Flags: needinfo?(mkelly)
(In reply to Michael Kelly [:mkelly,:Osmose] from comment #10)
> is2ei: Thank you for the offer, but we haven't yet decided the design we
> want to use with the new date and time pickers, which is why I removed the
> "good first bug" label. I'd like to wait until we have something like that
> before we start work on this again.

Osmose: I see! Thanks for your comment.
Bumping this up to P2; I'm hearing more reports of queries behaving unexpectedly due to the time mismatch in the date filter.
Priority: P3 → P2
Couple of other people have been bitten by this. It's worth fixing. I'm going to grab it and see if I can get anywhere with it.
Assignee: nobody → willkg
Status: NEW → ASSIGNED

Gonna work on this for a bit

Assignee: willkg → mkelly
Assignee: mkelly → nobody
Status: ASSIGNED → NEW

willkg committed PR #4814 in d9d5fd8 https://github.com/mozilla-services/socorro/commit/d9d5fd857432964758c6213e0d14499c0f63a277

When that deploys to stage, I'll ask for help varifying it and making sure I didn't miss anything.

Email sent to stability asking for feedback. I'll see how that goes.

Liz said it looked good. I didn't hear from anyone else.

This went to prod just now in 364. Marking as FIXED.

If there are UX/UI nits we need to address to improve it, we can do that in new bugs.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

very nice

Depends on: 1530204
No longer depends on: 1530204
You need to log in before you can comment on or make changes to this bug.