Closed Bug 1438014 Opened 6 years ago Closed 6 years ago

Update Debugger Frontend v16

Categories

(DevTools :: Debugger, enhancement, P3)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file, 3 obsolete files)

rel-16-4.patch
244.23 KB, patch
jdescottes
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch rel-16.patch (obsolete) — — Splinter Review 

        Attachment #8950734 -
        Flags: review?(jdescottes)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        rel-16-2.patch (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #8950734 -
        Attachment is obsolete: true

        Attachment #8950734 -
        Flags: review?(jdescottes)

        Attachment #8950764 -
        Flags: review?(jdescottes)

    
    

    
  
Comment on attachment 8950734 [details] [diff] [review]
rel-16.patch

Review of attachment 8950734 [details] [diff] [review]:
-----------------------------------------------------------------

- Meta:
 - assigned, P3, enhancement, blocks meta: added
 - commit message: ok
 - less than 20 commits: ok
- TRY
 - try run green: KO missing
 - try run has rebuild: KO missing
- Manual test
 - OK
- README review
 - compare link: OK
 - commit link: OK
 - version number: OK 
- Properties file review: OK
- New files: OK

Needs try runs + sync from Bug 1434374

::: devtools/client/debugger/new/test/mochitest/browser_dbg-chrome-create.js
@@ +6,5 @@
>  /**
>   * Tests that a chrome debugger can be created in a new process.
>   */
>  
> +const { BrowserToolboxProcess } = Cu.import(

Needs sync from mass refactor https://bugzilla.mozilla.org/show_bug.cgi?id=1434374

        Attachment #8950734 -
        Attachment is obsolete: false
Assignee: nobody → jlaster
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3

    
    

    
  

      
      
      
      

        Attached patch
          
          
        rel-16-3.patch (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #8950734 -
        Attachment is obsolete: true

        Attachment #8950764 -
        Attachment is obsolete: true

        Attachment #8950764 -
        Flags: review?(jdescottes)

        Attachment #8951059 -
        Flags: review?(jdescottes)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        rel-16-4.patch
        — 
          — Splinter Review
      

    


  

        Attachment #8951059 -
        Attachment is obsolete: true

        Attachment #8951059 -
        Flags: review?(jdescottes)

        Attachment #8951079 -
        Flags: review?(jdescottes)

    
    

    
  
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7598d4ba066f
Update Debugger Frontend v16. r=jdescottes

        Attachment #8951079 -
        Flags: review?(jdescottes) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/7598d4ba066f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago

          status-firefox60:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
See Also:  → 1438797

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.