Closed Bug 1438024 Opened 8 years ago Closed 8 years ago

Remove some shim-only XUL XPIDL interfaces

Categories

(Core :: XUL, enhancement)

Product:
Core
Component:
XUL
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: adrian17, Assigned: adrian17)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

Bug 1438024 - Remove nsIContainerBoxObject.
59 bytes, text/x-review-board-request
bzbarsky
: review+
Details
Bug 1438024 - Remove nsIScrollBoxObject.
59 bytes, text/x-review-board-request
bzbarsky
: review+
Details
Bug 1438024 - Remove nsIMenuBoxObject.
59 bytes, text/x-review-board-request
bzbarsky
: review+
Details
1438024-comm-central.patch (v1b)
2.07 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
No description provided.
Assignee: nobody → adrian.wielgosik
Status: NEW → ASSIGNED
Blocks: 1387169
There is one use of a removed interface (two, including a comment) in comm-central: https://searchfox.org/comm-central/search?q=nsIMenuBoxObject&case=false&regexp=false&path= https://searchfox.org/comm-central/search?q=nsiscrollboxobject&case=false&regexp=false&path= What's the general approach toward these?
Flags: needinfo?(bzbarsky)
General approach is to cc Jorg <jorgk@jorgk.com> on either this bug or a new bug you file on comm-central. In this case the fix is pretty simple: remove that whole .QueryInterface call.
Flags: needinfo?(bzbarsky) → needinfo?(jorgk)
Thanks, if you don't mind, I'll attach the patch here.
Flags: needinfo?(jorgk)
Attached patch 1438024-comm-central.patch (v1) (obsolete) — — Splinter Review
Philipp, how would you like to handle the comment? I've just remove the "since" clause.
Attachment #8950783 - Flags: review?(philipp)
Attachment #8950783 - Flags: review?(bzbarsky)
Comment on attachment 8950783 [details] [diff] [review] 1438024-comm-central.patch (v1) You could just say "doesn't implement ScrollBoxObject". r=me
Attachment #8950783 - Flags: review?(bzbarsky) → review+
Comment on attachment 8950757 [details] Bug 1438024 - Remove nsIContainerBoxObject. https://reviewboard.mozilla.org/r/220000/#review225836
Attachment #8950757 - Flags: review?(bzbarsky) → review+
Comment on attachment 8950758 [details] Bug 1438024 - Remove nsIScrollBoxObject. https://reviewboard.mozilla.org/r/220002/#review225838
Attachment #8950758 - Flags: review?(bzbarsky) → review+
Comment on attachment 8950759 [details] Bug 1438024 - Remove nsIMenuBoxObject. https://reviewboard.mozilla.org/r/220004/#review225840
Attachment #8950759 - Flags: review?(bzbarsky) → review+
OK, tweaked the comment to go with Boris suggestion :-) I forgot to say: Thanks for the head-up. Much nicer to fix it before it breaks.
Attachment #8950783 - Attachment is obsolete: true
Attachment #8950783 - Flags: review?(philipp)
Attachment #8950786 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/a72b573940c8 https://hg.mozilla.org/mozilla-central/rev/cfa6d11fe286 https://hg.mozilla.org/mozilla-central/rev/0457cb937b8e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/752150efa9fb remove use of nsIMenuBoxObject and nsIScrollBoxObject (comm-central part). r=bz
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: