1438035 - Add Unicode support for profile name of switch_profile()

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Bug 1429759 implemented profile switching for Marionette. But that doesn't work yet for profile names given as Unicode. We should make it transparent for consumers of Marionette like this:

> self.marionette.instance.switch_profile("mozrunner")
> self.marionette.instance.switch_profile(u"mozrunner-\u0425\u0435\u043D")
> self.marionette.instance.switch_profile(u"mozrunner-Хен")

That means that `_update_profile` will have to encode the profile directory to the filesystem supported encoding before passing the path to `tempfile.mkdtemp()`.

This feature is necessary to create tests for bug 1423897.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1438035 - [marionette] Add Unicode support for profile path in switch_profile().

The format string for the profile path in _update_profile caused
encoding problems if the profile name is a unicode string.

Review commit: https://reviewboard.mozilla.org/r/220350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220350/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It works all just fine except for test_capabilities.py where we have some external code from lib-tk running which actually forces the path to be a `str` and not a `unicode` string. The call to this code was added by bug 1369670 to circumvent the problem in our assert for uppercase and lowercase situations.

I think we should get rid of this fix given that it doesn't affect us in automation, and we just do a non case-sensitive check.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1438035 - [marionette] Remove case-sensitive check for profile path.

Review commit: https://reviewboard.mozilla.org/r/220440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220440/

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8951092 [details]
Bug 1438035 - [marionette] Add Unicode support for profile path in switch_profile().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220350/diff/1-2/

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8951092 [details]
Bug 1438035 - [marionette] Add Unicode support for profile path in switch_profile().

https://reviewboard.mozilla.org/r/220350/#review226396

Comment 6

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8951182 [details]
Bug 1438035 - [marionette] Remove case-sensitive check for profile path.

https://reviewboard.mozilla.org/r/220440/#review226398

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccfb3473baff
[marionette] Remove case-sensitive check for profile path. r=ato
https://hg.mozilla.org/integration/autoland/rev/2eecb43376ba
[marionette] Add Unicode support for profile path in switch_profile(). r=ato

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ccfb3473baff
https://hg.mozilla.org/mozilla-central/rev/2eecb43376ba