1438112 - Evaluate the impact and remove the templated AutoTimer

Status: NEW

(Toolkit :: Telemetry, enhancement, P3)

Description

[Alessio Placitelli [:Dexter]]

This is about following up bug 1436680: can we remove the templated AutoTimer? Do we incur in any performance loss on hot paths? We should:

- Create a patch to use the RuntimeAutoTimer instead of AutoTimer<ID>
- Trigger a Talos build
- Watch out for regressions
- If there are no regressions, land the patch.

Context:

(In reply to Alessio Placitelli [:Dexter] from bug 1436680 comment #7)
> (In reply to Chris H-C :chutten from bug 1436680 comment #5)
> > Looking at the users of AutoTimer[1] there are some potential hot paths that
> > could be affected (nsThread stands out as a potential). No doubt talos will
> > catch us if we do anything _too_ egregious, but perhaps we should stick to
> > adding a runtime-specifiable edition of autotimer, leaving the old one alone.
> > 
> > [1]:
> > https://searchfox.org/mozilla-central/search?q=symbol:
> > T_mozilla%3A%3ATelemetry%3A%3AAutoTimer&redirect=false
> 
> Fair enough. One approach we could have would be to add the non templated
> version in this bug, then file a follow-up for evaluating changing the
> templated version to the newly added one. There we could simply trigger a
> talos build on try to decide :)

Comment 1

[Jeremy Lempereur [:o0ignition0o]]

Oh, I created Bug 1437953 :/ I'll mark it as a duplicate :)