Closed Bug 1438113 Opened 2 years ago Closed 2 years ago

Make it possible to have wasm baseline without wasm ion

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: lth, Assigned: lth)

References

Details

Attachments

(1 file, 1 obsolete file)

For ARM64 we'll initially only have baseline, and we'll be in the situation where we can support wasm but not asm.js, and we can't use ion as a fallback if the baseline compiler has been disabled by pref or or command line option.  Previously we could have ion without baseline; we just need to make the situation symmetric.
Attached patch bug1438113-optional-ion.patch (obsolete) — Splinter Review
Make compiler selection more subtle.  See commit msg for more.
Comment on attachment 8950860 [details] [diff] [review]
bug1438113-optional-ion.patch

Make compiler selection more subtle.
Attachment #8950860 - Flags: review?(luke)
Comment on attachment 8950860 [details] [diff] [review]
bug1438113-optional-ion.patch

Review of attachment 8950860 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense
Attachment #8950860 - Flags: review?(luke) → review+
Rebased, etc, ready to land.  Carrying r+.
Attachment #8950860 - Attachment is obsolete: true
Attachment #8954025 - Flags: review+
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e46ff4ff446
Make it possible to have wasm baseline without ion. r=luke
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef89c3c179cd
add missing include files, r=bustage ON CLOSED TREE
https://hg.mozilla.org/mozilla-central/rev/6e46ff4ff446
https://hg.mozilla.org/mozilla-central/rev/ef89c3c179cd
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.