Loosen webdriver crate version dependency on log

RESOLVED FIXED in Firefox 60

Status

enhancement
P3
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: ato, Assigned: eijebong)

Tracking

Version 3
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

webdriver depends on v0.3 of the log crate and this causes us to
have multiple copies of log under third_party/rust.  We should
loosen the version dependency to "^0" so we can keep only one copy.

Perhaps other crates, such as code under testing/mozbase/rust and
testing/geckodriver also need updating.
Reporter

Updated

Last year
Priority: -- → P3
FTR depending on "^0" is unsafe and may not even be supported by cargo. 0.x versions are mutually incompatible and so it's unsafe (in the sense that the build can fail) to depend on anything starting with a 0.

I will gladly accept a patch to bump the version to 0.4, however.
Reporter

Comment 2

Last year
This was mentioned on IRC by the contributor who wanted to patch this.
I’d be fine to accept "0.4".

As an aside I think it is fairly unlikely that a widely deployed
crate such as log’s API will change, but it is fine to wait for
a 1.0 version in order to employ a "^1" requirement.  The obvious
benefit to this is that we don’t have to spend cycles doing this
upgrade dance every time we end up having mutally incompatible
dependencies on log throughout central.
Comment hidden (mozreview-request)
Reporter

Comment 4

Last year
mozreview-review
Comment on attachment 8951214 [details]
Bug 1438195 - Update log to 0.4 in webdriver and bump version.

https://reviewboard.mozilla.org/r/220478/#review226422

You also need to run "./mach vendor rust" so that the lock files and third party dependencies are updated.

::: testing/webdriver/Cargo.toml:3
(Diff revision 1)
>  [package]
>  name = "webdriver"
> -version = "0.33.0"
> +version = "0.33.1"

This should probably be bumped to 0.34.0 since there are other changes to the crate besides this.
Attachment #8951214 - Flags: review?(ato) → review-
Comment hidden (mozreview-request)
Reporter

Comment 6

Last year
mozreview-review
Comment on attachment 8951214 [details]
Bug 1438195 - Update log to 0.4 in webdriver and bump version.

https://reviewboard.mozilla.org/r/220478/#review226600

Thanks for the patch!
Attachment #8951214 - Flags: review?(ato) → review+

Comment 7

Last year
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5093b65f67bb
Update log to 0.4 in webdriver and bump version. r=ato
Reporter

Updated

Last year
Assignee: nobody → eijebong
Status: NEW → ASSIGNED

Comment 8

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/5093b65f67bb
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.