1438339 - Remove the talos_* pageloader browser preferences after each test run

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Robert Wood [:rwood]]

In order to tell pageloader the test specifics i.e. manifest, tppagecycles, etc. talos sets 'talos_*' browser preferences, and the pageloader addon reads those preferences and applies them to the test. Which works great, however I noted we are not un-setting these browser prefs after the test is finished,

This can cause issues when there are multiple pageloader tests in the same talos suite, that don't define the same types of test options.

For example, if the first pageloader test uses the 'cycles' setting, a corresponding 'talos_cycles' browser pref is set for pageloader to use for that test, as expected. Then if a following pageloader test in the same suite runs, but it doesn't have 'cycles' defined / required for that test - it picks up the existing 'talos_cycles' browser pref anyway and applies that to the current test, incorrectly.

Comment 1

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c73b33465325fe7d247b7512790d219b06ff9ebd

Comment 2

[Robert Wood [:rwood]]

Attachment: Bug 1438339 - Remove the talos_* pageloader browser preferences after each test run;

Review commit: https://reviewboard.mozilla.org/r/220518/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220518/

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8951259 [details]
Bug 1438339 - Remove the talos_* pageloader browser preferences after each test run;

https://reviewboard.mozilla.org/r/220518/#review226464

this looks really good

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fa6e41a00df
Remove the talos_* pageloader browser preferences after each test run; r=jmaher

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5fa6e41a00df