Snippet blocks are still not syncing between about:home and about:newtab

RESOLVED FIXED in Firefox 60

Status

()

defect
P1
normal
RESOLVED FIXED
a year ago
2 months ago

People

(Reporter: Gijs, Assigned: andreio)

Tracking

Trunk
Firefox 60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

(Reporter)

Description

a year ago
STR:

1. ./mach run (or otherwise open nightly on a clean profile)
2. on the homepage with AS, get rid of the onboarding
3. click the [x] on the first snippet you get
4. open devtools console and check gSnippetsMap.blockList
5. open a new tab
6. open devtools console and check gSnippetsMap.blockList

ER:
they match up
AR:
they do not match up.
(Reporter)

Updated

a year ago
See Also: → 1438367
kate, take a look at this
Flags: needinfo?(khudson)
Assignee: nobody → khudson
Flags: needinfo?(khudson)
Iteration: --- → 60.4 - Mar 12
Priority: -- → P1
(Assignee)

Updated

a year ago
Assignee: khudson → andrei.br92
After some investigation, andrei noticed that snippets are not currently using blockSnippetById, so fixing that in snippets_as.js in snippets-server will fix part of the problem,

the other thing we talked about was adding the blocklist to snippets feed backed by IndexedDB

Comment 3

a year ago
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/ef10b886ba19e847c4ae68df567d63c774c07cb5
Fix Bug 1438368 - Syncing blocked snippets between about:home and about:newtab.

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED

Updated

a year ago
Blocks: 1443928

Comment 4

a year ago
Commit pushed to master at https://github.com/mozmeao/snippets-service

https://github.com/mozmeao/snippets-service/commit/1b436e4e8640507ee01a1ef36588fc03c9779f19
Switch to gSnippetsMap.blockSnippetById (#367)

* Fix Bug 1438368 - Snippet blocks are still not syncing between about:home and about:newtab

* Remove snippets in blocklist check.

gSnippetMap.blockSnippetById() checks for duplicates.
(Assignee)

Updated

a year ago
Blocks: 1430859
You need to log in before you can comment on or make changes to this bug.