Closed Bug 1438433 Opened 2 years ago Closed 2 years ago

Two network pref tweaks

Categories

(Core :: Networking, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox60 --- wontfix
firefox61 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

(Whiteboard: [necko-triaged])

Attachments

(2 files)

I have a couple of network pref tweaks.
Priority: -- → P1
Whiteboard: [necko-triaged]
Comment on attachment 8951153 [details]
Bug 1438433 - Remove the network.predictor.redirect-likely-confidence pref. .

https://reviewboard.mozilla.org/r/220416/#review226850
Attachment #8951153 - Flags: review+
Comment on attachment 8951154 [details]
Bug 1438433 - Don't set Predictor::mCleanedUp directly. .

https://reviewboard.mozilla.org/r/220418/#review226856

We can't set the value in prefs until PredictorThreadShutdownRunner::Run happens, as the cleanup could fail for a transient reason, and we would want to try again at the next startup in that case.

We can probably just make mCleanedUp a copy (not cache) of the value in prefs at startup, and leave this direct modification as-is.
Attachment #8951154 - Flags: review-
Comment on attachment 8951154 [details]
Bug 1438433 - Don't set Predictor::mCleanedUp directly. .

https://reviewboard.mozilla.org/r/220418/#review233014

LGTM, but the first line of the commit message needs a bit of rewording. Sorry for the lag, got lost in my mess of open tabs!

::: commit-message-e8606:1
(Diff revision 2)
> +Bug 1438433 - Don't set Predictor::mCleanedUp directly. r=hurley.

This no longer matches the change being made, which makes the commit message confusing.
Attachment #8951154 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/95dbe9cb93d791ceca6738218824b38a5094c1c5
Bug 1438433 - Remove the network.predictor.redirect-likely-confidence pref. r=hurley.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8eb82cefbd7aa68e080560b519feea5a86feefe1
Bug 1438433 - Make network.predictor.cleaned-up a non-VarCache pref. r=hurley.
https://hg.mozilla.org/mozilla-central/rev/95dbe9cb93d7
https://hg.mozilla.org/mozilla-central/rev/8eb82cefbd7a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.