Closed Bug 1438459 Opened 2 years ago Closed 2 years ago

[wpt-sync] PR 9516 - Make WPT webrtc/simplecall.html pass

Categories

(Core :: WebRTC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

Details

(Whiteboard: [wptsync downstream])

The test was failing because passing a null ("end of candidates")
candidate to addIceCandidate is not permitted.

Spec link:

https://www.w3.org/TR/webrtc/#dom-rtcpeerconnection-addicecandidate
https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addicecandidate

Bug: none
Change-Id: I1f22d27393a482a882ebe9735488d8cb723b6e75
Reviewed-on: https://chromium-review.googlesource.com/918662
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536977}
Component: web-platform-tests → WebRTC
Product: Testing → Core
Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1
Michael, do you mind doing a first pass here?
Flags: needinfo?(mfroman)
This test already seems to pass on my linux box.  I'm not sure what there is to do here.
Flags: needinfo?(mfroman)
Rank: 29
Priority: -- → P3
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5186f2005eb6
[wpt PR 9516] - Make WPT webrtc/simplecall.html pass, a=testonly
https://hg.mozilla.org/mozilla-central/rev/5186f2005eb6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.