Closed Bug 1438540 Opened 6 years ago Closed 6 years ago

Duplicated/miscopied wasm tests in conversion.js

Categories

(Core :: JavaScript Engine: JIT, defect, P1)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1435369

People

(Reporter: lth, Unassigned)

References

Details

Starting around line 296 in jit-test/tests/wasm/conversion.js there are five tests that are identical to five tests a few lines above.  These are supposed to be here, but I think the third argument is supposed to be 'f64'.

These:

testTrap('i32', 'trunc_u', 'f32', 'nan');
testTrap('i32', 'trunc_u', 'f32', 'infinity');
testTrap('i32', 'trunc_u', 'f32', '-infinity');
testTrap('i32', 'trunc_u', 'f32', -1);
testTrap('i32', 'trunc_u', 'f32', p(2,32));

Presumably the last argument to the last one might need to be something else for f64, not investigated yet.
There's a fix for this in my patch in bug 1435369.
That patch has now landed on inbound.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.