Closed Bug 1438559 Opened 7 years ago Closed 7 years ago

Add Ecosia for German Firefox

Categories

(Firefox :: Search, enhancement)

Product:
Firefox
Component:
Search
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
relnote-firefox --- 59+
firefox59 + verified
firefox60 + verified

People

(Reporter: mkaply, Assigned: mkaply)

Details

(Keywords: feature)

Attachments

(3 files)

ecosia.ico
3.26 KB, image/x-icon
Details
Bug 1438559 - Add Ecosia for German Firefox.
59 bytes, text/x-review-board-request
flod
: review+
lizzard
: approval-mozilla-beta+
Details
errors.gif
1.69 MB, image/gif
Details
We're going to be shipping Ecosia in German Firefox starting with Firefox 59. [Tracking Requested - why for this release]: This is a new partnership.
Search feed implementation: https://www.ecosia.org/search?tt=mzl&q={{searchTerms}} Autosuggestion: https://ac.ecosia.org/?q={searchTerms} You should be able to use this URL endpoint to retrieve autosuggestions in JSON format. If you need the results in Opensearch-style, you can use: https://ac.ecosia.org/autocomplete?q={searchTerms}&type=list https://www.ecosia.org/opensearch.xml
Attached image ecosia.ico —
32+16px minimized .ico, just in case
Assignee: nobody → mozilla
Comment on attachment 8951325 [details] Bug 1438559 - Add Ecosia for German Firefox. https://reviewboard.mozilla.org/r/220584/#review226558 The searchplugin works, but: 1) Nit: I think the explicit Params are more readable. 2) If I set it as default, the console is littered with warnings when it searches for suggestions. Is it the case also for you? SearchSuggestionController: Non-200 status or empty HTTP response: 503 SearchSuggestionController.jsm:336 _dedupeAndReturnResults resource://gre/modules/SearchSuggestionController.jsm:336:9 _dedupeAndReturnResults self-hosted:978:17 ::: browser/locales/searchplugins/ecosia.xml:10 (Diff revision 1) > +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/"> > +<ShortName>Ecosia</ShortName> > +<Description>Search Ecosia</Description> > +<InputEncoding>UTF-8</InputEncoding> > +<Image width="16" height="16">data:image/x-icon;base64,AAABAAIAEBAAAAEAIACNAwAAJgAAACAgAAABACAAWAkAALMDAACJUE5HDQoaCgAAAA1JSERSAAAAEAAAABAIBgAAAB/z/2EAAANUSURBVDiNVZNLbFRVAIa/c+69c2em005Lh2nTh9TSQkmFEqWhVAFREpHiBmnwEUlc2DVVE90YIXFljIboRhcmahQbNIguaAyPFMRW0UiA1pa0pS2ddtoy0+m8753OOS4U1H///Ys//yf4T/Tbu03SJZ0Yxkv4A4/jLalFGgb5dJRsaohi4Qv82XPi+ED+HiPuw292VaBFrwrV99DaWeU2tOIEgiAkdi6JPXsLMTyYYHa8D+2+I97tn71foN/oDiIL76mN7S+7ew4aybIoQ4vz9M/VkS16CPu9dFZVstOrqRj8AXntQj/Z1R7x/pk7hgbBY41H1YZHXst3PW98HZ9jLNrHjViSq/EKfHqCpUyUXxaWWBFJWh7uwOsUm0R03H9sb/U5k9f3txEM97i7njUurvzJ6cllltwuvLLAvvAVnqgcQiPIFH14ZY5EdjuBR3uwIhOH5czoWYngIM1bG274QpwYtog6IQrKYkPgNrsrryKEptTMUGMvUWGlyWUHSNqj6NYd5ZjWixLL3qkaNonf4zHiThEQhDwJ9q29jE/mWSmU4ioL/c9gGodM7gqqvhH8pTsklq9WlZaz2X+WTYEJlJZUWCtU23expUutdxFbusw7axlJr8dVHhz3LqrEh7J91RKhtdZQ71vkSN13rC+ZYTpXw8fTzzGeWYcQinTRT9/cfk5GDvBV5ADXUy1IFICSuLlpmYjh8TSCEBSUSUFZDKeamHPCSBQ/xbcxnGomkq/icmwbSf0QRjKNzKYjkkLhvJi8WTRlJ98vvsCdXBVSKKRQCDTzTphIPowpimjANi3WBbcgp8YglxqQFNVpOXl9rCzq0lq9C1MKtAaN4GJsO5/OHOLX5TZcZQLw1AO1dJCFm0MLaPW5cXxwPHasvb4oEot7N25pN83Scm4n0+RWV4m7ZSy55SgEAcvimQfreKVuDcELJ5WYGv4Qf/qzv6/c2+3D47yl1rX0ru457B0J1vJzLMl0KoPSmpoSHx2hctrcBN5L3xTl6G9f4uR6xQc/xv+Vqbfbh5U7QtmaozRtbVaNm41CMIQWAiudwJga0dz6Y5bl+U/IGx+JE2cS/7MRQIPg1aebMeQhLPtJbG8dQkgcZwEnewktvmXGf02cOlW8x/wFXpVyU8novdAAAAAASUVORK5CYIKJUE5HDQoaCgAAAA1JSERSAAAAIAAAACAIBgAAAHN6evQAAAkfSURBVFiFlZd5jF5VGcZ/77n3u982+z7Tmelm95WCQqFQChKWmgGEkgZjihITFzAqKqKJpQgSE40xSKJN/EMCcSG2FChWFqu0UFqxO3QBOp3OTKezz3zz7ffe8/rHtEM3WU5yk3tu7n2e533f57z3HOETDF271pDb34TRq4HlYBcATSh1gIfIAGgvYg4DOyDcild1VNb9Mf9x2PKxxMUDMyFcjdKGtTMwUoIXAy+Guh6IQOAjfhEKObBhAaEHzGuofYpscac8saXwqQXog6vKkcIaVL6B2pnEk8Y2TkWnzEUbpkB5DZosA8dBchlIDSED3ciJI8iJw0hqCGAA+AuO/Foee+6DTyxAH7x1CkYeQe1deLGonb4Ie8kKdPIcJF6CGINvQ0Jrx0FE8IwzjlbMo31dmANvYA5sR0YHFSNvAw/hLd4q69bZjxSgP/riNAh/C9ys1Q2Ey25D518JsRLyfpYPUmPsGxzj+FiOQhgC4IhQn4gxp6KM2ZVl1MbjGA3h+CHM63/DHDsI2ONYvscvnn9OQC8qQH94ezPG/g50pU6aQXDzPdA6i2Lok8luoy/1MkdGhmnPlLK5dxkpvwQRnQCKuw4tyQTXTarnppZG6pNxdHQQZ+tfMXv/BWHQgci98vim185wOhPka9fEsLlHUL1bJ02XoO1r0DKL7kyODe/vwsv/kogeoMQZZiwo4UBqDgEeIAgGMARWGSgU2TMwwoGhMepiMZqqa2DybCSTQk4drwDmPLxs5tZ1248OAbgT4RdGbkX5spZVSfj5u2HSTPL593nq0FHe7E3j10+lO38F3bkGuvP1jAVJIsZnVmk7s5LtDBQrOZKZRi6M4kjIQKaPje8dotKdw8zqSwlX3AUjfZgP9n8WzHf0/psekCe2FFwAfWhVLep/C8eU2c/diE5fSBiconvwSdK5Cob8pfyp+wsE6qIqRE2R2ugQzbFT3NOygTI3TaAOA8UqMmGciASUuhliJotmasnEf0yifCnhNXcgfV1Iamg1JfFNwCvjGVD/FjS8XOunYBcvJ0DY2nmQF9pbac9OQlBCdRAUFaj2hvlKywbiToFSN4MiOGJpiPaPe0IFBRRBw24GRtbT5E3GnTwXu2AZzpsvVIP9kq5ds83o2lUloG04rmcXXo1U1HJkeJQnDxveHpnHkF9xwbptiA5QFx2kOd6DfGhoFMGqwSLohL8NucJBRtMvgTHYBVehpRWgrMAfmW3IB9OBy7S0CjtjMYFVXu46RV+uiBG9gMAzPstrdlHiZjmankpPoY5QHT56hIxlXiUIeqGuBW2ZBWobQW4wSLgEqzVa34JU1DKQL7C7f/iiMI6ELK3cw/TECQyWysgo+1Mz2Z+aRTpIfIQAQ9HvJF94F/US4wKME0G53IDMQTShtS3gxejNpOjPZQFzDoRFmJU8zu0Nr5B0cihCjTfM9TU7mJHswJHwvFLpOXPVHPnCofH7umaIxkF1tkFoRgyUV6PGpcbdR1v9S1R7I2fVcXy0xHsmTHemJI5YSt00Cadwmnj8+ViQPOd7VYsf9qJaRJMV4HoATQYliuOi0QSKEOMk19ds487GLcSd/IcgCr2FagrWO22xc71xZlawEXaNLOT3Has5lm3BiJIPo1gcVH3QEBIlqBsBtPLDRnQGQhxAuLTiHXI2zsv9y+grVGFEOZSextNdbdRHB1lUdpjW+MlzojRi2T06j6e72siEcSbFeylz0zx78mbml77LypIz9QxBLSjWBdKEPpIdA8BxakBcXIpcV/0WBssz3W2EaihajzeHl6AqDBQrWdOycSJ2QRnxy9g9Oo9sGMeIsm90NpkgwX9H5zLqx1jRPIYRB3JpJAhAGHAR6SC0KiP9IoGPF2nFSJxQixTVpT3bTKBmIk5BUYRThRqKNkLUFBGUYb+Mp7tuZV9qNkbG/7j9xSr6i1WoGkrcIkmvEYyHjPRDMQ8qHQY4iCEtJ49BPk3EbcCLtGAV9o7OYW9qDhfbNpS7adzTzhdR+ovVHM1MxZ63es6UN23rkcglYEOk9wT4eRAOGUz4H5AuGeyB/k4ct4pk/Cp2jy7kme42UkHJBUsKIOoUJyLNhTE6sk0srdxDwslf8LZiKY9NJxmdAbkx5Pi7YMmi8m9Df2MXYraRHcMcfhuxFjfexs6xOxnxkxclBxgqluNbF0csu0YWsnt0HkYsvnXPyZcCCdfhltZGyqMecuIIpqcdhGO44VYj69f7qGwEHTXv7IDeDspj9axonk/MMRelF1FO5Bp5a3gxbw0vYkvf1RzNTOG1gSsJzm/LCsub6rimqQ7NZzB7tkI+C0Y24S7pcAAevrylB8ebL/nsPAlDdPoCplaWM1r0OTKSQs9zgQC+Rjicnsae1FxGg7KJBnQOt8KimgrumzeD2kQM2fc6zs6/gw3eQ/iJPLq+zwDIr17J4PAbVDvNwTeQ3VuJGcO9s6dx29RmPGOwemEu8tajaCMXtt3T15LaSr6/aDaTy0rRzqM42zdBMeeDrOfx5w/BWVuyh69b3Y3tCwmCa6SnPaIVNcQaJ7OktoqqqEdnJkvKD1BVEEHOy4qeDlmBiqjHytYmvjlvBpPLStBTHbib/4CcOg7IsxA8Ktvfy8H5m9IHbkjiJR7B2vu0rNoLr70TXXwtGonSnhrj1a5T7OwboiuTpRCEhKcJjQieMVTHPC6pqeSG5gYWVFcQNQbtOIT7j6eQrvcB2YZr7pVHN7x3djnPTd+Dq8oxxZ9i+TrRWMIuXEZ4xUqkrhkrwnCuwIl0hs50lpTvg4LnGJqTCVpLk9TFY3iOg44NYw5sx+zYjAz3KWL+iep35RebDpzNd/GDydpVJRQKXwV+ANKsNU3Y+VdiZ12G1DRBNI6YM9Ubt6iqgl9AU4NI+0GcfduRziMQBhmQP+OYn8ljGzrO5/r/R7NVqxw+E16Bht8GeyOYci2tROtb0capUFGLRhPgOFDIIWPDSF8ncvIDZGQAgqKPMXtRniDqbZR1z6YvxvORh9OJbPj+1VjuQHU5ahtAEzgRg+OAGLABBAFAAdFBRHaDvIgEL/LzzSfPPgl9agETQu6/KUp5opXAXgbMB6agGjuNYkF6QA9jdBeR4lFZtyX1SXD/Bx0GNdANagcMAAAAAElFTkSuQmCC</Image> > +<Url type="application/x-suggestions+json" template="https://ac.ecosia.org/autocomplete?q={searchTerms}&amp;type=list"/> Can we use explicit Params here? <Url type="application/x-suggestions+json" method="GET" template="https://ac.ecosia.org/autocomplete"> <Param name="q" value="{searchTerms}"/> <Param name="type" value="list"/> </Url>
Comment on attachment 8951325 [details] Bug 1438559 - Add Ecosia for German Firefox. https://reviewboard.mozilla.org/r/220584/#review226558 I am not seeing those. Can you give me some search terms you were using? > Can we use explicit Params here? > > <Url type="application/x-suggestions+json" method="GET" template="https://ac.ecosia.org/autocomplete"> > <Param name="q" value="{searchTerms}"/> > <Param name="type" value="list"/> > </Url> Yes, I'l do that.
(In reply to Mike Kaply [:mkaply] from comment #5) > Comment on attachment 8951325 [details] > Bug 1438559 - Add Ecosia for German Firefox. > > https://reviewboard.mozilla.org/r/220584/#review226558 > > I am not seeing those. Can you give me some search terms you were using? It doesn't seem to depend on the term: 1) Installed engine from https://l10n.mozilla-community.org/~flod/testsp/ in a clean profile, set it as default. The XML is https://l10n.mozilla-community.org/~flod/testsp/ecosia.xml 2) I write my own last name "lodolo", and get a couple of those. If I delete characters, typically two in a sequence, I get the notification.
Weird. I'm not seeing that on Nightly.
Attached image errors.gif —
Tried with a second connection, but I have the same behavior. 60.0a1 (2018-02-15) (64 bit)
Ecosia is having issues per dicussion with their CTO. I've updated the patch per your request.
(In reply to Mike Kaply [:mkaply] from comment #9) > I've updated the patch per your request. Forgot to push the updated version to MozReview?
Comment on attachment 8951325 [details] Bug 1438559 - Add Ecosia for German Firefox. https://reviewboard.mozilla.org/r/220584/#review226824 Looks good. I'm also not seeing those errors anymore on suggestions, I guess they solved the issue.
Attachment #8951325 - Flags: review?(francesco.lodolo) → review+
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/2f76fdc4ee3e Add Ecosia for German Firefox. r=flod
Tracking for 59 since it looks like we're going to need uplift here. Do you have testing lined up?
status-firefox59: --- → affected
tracking-firefox59: ? → +
tracking-firefox60: --- → +
Flags: needinfo?(mozilla)
> Do you have testing lined up? I do not. I was planning to test once it landed. What's the best way to handle small one off test requests like this?
Flags: needinfo?(mozilla)
https://hg.mozilla.org/mozilla-central/rev/2f76fdc4ee3e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
I think likely putting in a PI request (https://mana.mozilla.org/wiki/display/PI/PI+Request) describing what you need and the timeline. If it is pretty simple and easy to describe you could also n-i to :avaida and describe the STR/verify in the bug.
This is a really simple STR for verification. Run latest German nightly. Verify that Ecosia is available as a search engine (globe). Verify that a search on Ecosia has the code tt=mzl. Any help you could provide would be awesome. I've verified, just need someone from QA to do so as well.
Flags: needinfo?(andrei.vaida)
Comment on attachment 8951325 [details] Bug 1438559 - Add Ecosia for German Firefox. Approval Request Comment [Feature/Bug causing the regression]: Add new search partner, [User impact if declined]: [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: Install German Firefox. Verify Ecosia is there and works. [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Just adds new engine for German only [String changes made/needed]: None.
Attachment #8951325 - Flags: approval-mozilla-beta?
Comment on attachment 8951325 [details] Bug 1438559 - Add Ecosia for German Firefox. Adding new engine for a partner deal. Andrei can your team verify this for de locale? thanks!
Attachment #8951325 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I have verified that the Ecosia search engine works as expected (per comment 19) using Firefox 60.0a1 (BuildId:20180220220044) "de" build on Windows 10 64bit, macOS 10.13 and Ubuntu 16.04 64bit. I have also performed some more exploratory testing and no issues were encountered during this process. Leaving a ni? on myself to verify this on beta as well.
Status: RESOLVED → VERIFIED
status-firefox60: fixed → verified
Flags: needinfo?(andrei.vaida) → needinfo?(emil.ghitta)
This is also verified fixed on Beta 59.0b13 (20180226180053) using a "de" build, across the following platforms: Windows 10 x64, macOS 10.13 and Ubuntu 16.04 x64.
status-firefox59: fixed → verified
Flags: qe-verify+
Flags: needinfo?(emil.ghitta)
Release note: Added the Ecosia search engine as an option for German users Mike - let me know if you want to phrase that differently in the release notes. "German Firefox" "de locale"?
relnote-firefox: --- → 59+
Flags: needinfo?(mozilla)
Let's go with German Firefox since it's only in that locale (not en-US users in Germany)
Flags: needinfo?(mozilla)
"Added the Ecosia search engine as an option for Firefox in German"? "German Firefox" sounds a bit weird to me.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: