1438574 - Rust SDP parser should not fail to parse unknown group semantics

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P3)

Description

[Dan Minor [:dminor]]

At the moment, it fails with a parse error. It should either ignore them or return something indicating it was unknown.

Comment 1

[Johannes Willbold]

Attachment: Bug 1438574: Changed unknown group semantic handling,

Unknown group semantics are no longer an error but a warning indicating that the lines was skipped.
Made rust unit test test_parse_attribute_group more explicit.

Review commit: https://reviewboard.mozilla.org/r/252926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252926/

Comment 2

[Dan Minor [:dminor]]

Comment on attachment 8987694 [details]
Bug 1438574: Changed unknown group semantic handling,

https://reviewboard.mozilla.org/r/252926/#review259604

::: commit-message-6e8e8:1
(Diff revision 1)
> +Bug 1438574: Changed unknwon group semantic handling, r=dminor

typo: s/unknwon/unknown/

Comment 3

[Johannes Willbold]

Comment on attachment 8987694 [details]
Bug 1438574: Changed unknown group semantic handling,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252926/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3df0a04b93e
Changed unknown group semantic handling, r=dminor

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f3df0a04b93e