1438615 - nsIToolkitProfileService.profileCount should return the number of profiles

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement)

Description

[Dave Townsend [:mossop]]

This bizarre API is just asking for confusion. Let's make it sane.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1438615: profileCount should actually return the number of profiles.

Review commit: https://reviewboard.mozilla.org/r/220620/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220620/

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8951363 [details]
Bug 1438615: profileCount should actually return the number of profiles.

https://reviewboard.mozilla.org/r/220620/#review227458

::: toolkit/profile/nsToolkitProfileService.cpp:960
(Diff revision 1)
>  NS_IMETHODIMP
>  nsToolkitProfileService::GetProfileCount(uint32_t *aResult)
>  {
> -    if (!mFirst)
> -        *aResult = 0;
> +    *aResult = 0;
> -    else if (! mFirst->mNext)
> +    nsToolkitProfile* profile = mFirst.get();

Why do you need the .get() calls here?

A few lines later there's the same code implemented as simply:

    for (cur = mFirst; cur != nullptr; cur = cur->mNext)
        ++pCount;

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8951363 [details]
Bug 1438615: profileCount should actually return the number of profiles.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220620/diff/1-2/

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8951363 [details]
Bug 1438615: profileCount should actually return the number of profiles.

https://reviewboard.mozilla.org/r/220620/#review227458

> Why do you need the .get() calls here?
> 
> A few lines later there's the same code implemented as simply:
> 
>     for (cur = mFirst; cur != nullptr; cur = cur->mNext)
>         ++pCount;

Can't remember why I did that. Seems to work fine without it. Updated the patch.

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8951363 [details]
Bug 1438615: profileCount should actually return the number of profiles.

https://reviewboard.mozilla.org/r/220620/#review227574

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4420500cda8
profileCount should actually return the number of profiles. r=florian

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/c4420500cda8