Closed Bug 1438641 Opened 4 years ago Closed 4 years ago

dom/media/test/reftest/gizmo.mp4.seek.html fails on new windows 10 hardware

Categories

(Core :: Audio/Video: Playback, defect, P2)

Product:
Core
Component:
Audio/Video: Playback
Version:
54 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file)

adjust filters to allow test to pass
1.18 KB, patch
bryce
: review+
Details | Diff | Splinter Review 
you can see many failures when on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=38d33764c8fcb54a270518d63f2b596a4f4dde30&filter-searchStr=reftest

we are getting new hardware to run windows 10 tests on and the tests are failing.

adjusting the existing fuzzy-if statement allows this to work:
skip-if(Android) fuzzy-if(OSX,25,175921) fuzzy-if(winWidget,71,179198) HTTP(..) == gizmo.mp4.seek.html gizmo.mp4.55thframe-ref.html
Comment on attachment 8951394 [details] [diff] [review]
adjust filters to allow test to pass

Bryce, does this make sense to you? If so, can you please get it landed?
Attachment #8951394 - Flags: review?(bvandyk)
Priority: -- → P2
Comment on attachment 8951394 [details] [diff] [review]
adjust filters to allow test to pass

Review of attachment 8951394 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Out of interest, what causes these (increased) differences?
Attachment #8951394 - Flags: review?(bvandyk) → review+
the new hardware is an intel video card vs nvidia- it is also much faster hardware, so timing will change.  windows 10 is the only platform we run reftests on hardware, the rest are on AWS VMs- this is more of a fact that we have had trouble running the graphics intensive tests on the windows 10 images.

Thanks for the review- happy to try any prefs out if there is a concern, etc.  I will probably land a few related patch together on Tuesday or Wednesday the next week.
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7fe8178c1d9
dom/media/test/reftest/gizmo.mp4.seek.html fails on new windows 10 hardware, add fuzzy-if. r=bryce
https://hg.mozilla.org/mozilla-central/rev/d7fe8178c1d9
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Assignee: nobody → jmaher
You need to log in before you can comment on or make changes to this bug.