1438682 - Google Pinyin IME duplicates text after switching focus

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

1. Focus one input using Google Pinyin IME in English mode
2. Focus another input with existing text
3. Type something
4. Existing word is duplicated

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1438682 - 1. Cache initial selection offsets;

Getting the selection offsets in onCreateInputConnection can fail
because of us being on a wrong thread. The solution is to cache the last
selection offsets and use those in onCreateInputConnection.

Review commit: https://reviewboard.mozilla.org/r/220758/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220758/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1438682 - 2. Implement dummy closeConnection;

closeConnection is a new API introduced in N. We don't really support it
at the moment but we also don't want the default behavior, so we
implement a dummy.

Review commit: https://reviewboard.mozilla.org/r/220760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220760/

Comment 3

[Eugen Sawin [:esawin]]

Comment on attachment 8951460 [details]
Bug 1438682 - 1. Cache initial selection offsets;

https://reviewboard.mozilla.org/r/220758/#review226852

Comment 4

[Eugen Sawin [:esawin]]

Comment on attachment 8951461 [details]
Bug 1438682 - 2. Implement dummy closeConnection;

https://reviewboard.mozilla.org/r/220760/#review226854

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f066f679fb04
1. Cache initial selection offsets; r=esawin
https://hg.mozilla.org/integration/autoland/rev/7ea185f4bce1
2. Implement dummy closeConnection; r=esawin

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f066f679fb04
https://hg.mozilla.org/mozilla-central/rev/7ea185f4bce1

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8951460 [details]
Bug 1438682 - 1. Cache initial selection offsets;

We should consider uplifting this because it's a really annoying bug.

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: Annoying bug when using some keyboards, resulting in duplicated text when entering text.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Not really.
[Why is the change risky/not risky?]: Small change to fix the bug.
[String changes made/needed]: None

Comment 8

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8951460 [details]
Bug 1438682 - 1. Cache initial selection offsets;

OK, let's uplift this for beta 12 (effectively, for the beta 13 mobile build) an verify in beta instead of in nightly.

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9a753ffaee47
https://hg.mozilla.org/releases/mozilla-beta/rev/2f2ff6d6864f

Comment 10

[Oana Horvath [:ohorvath - out of office]]

Verified as fixed on Beta 59.0b13
HTC 10 (Android 8.0)

Comment 11

[Stefan Deiac]

Remove qe-verify flag based on comment 10.