1438693 - browser_privacypane.js is going to permafail when Gecko 60 merges to Beta on 2018-03-01

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://treeherder.mozilla.org/logviewer.html#?job_id=162522293&repo=try

Bug 1426482 which added the file has status-firefox59 set to "affected". If that will be fixed on beta, forward-porting should be easy. At the moment, the tests return if the build isn't a Nightly.

[task 2018-02-15T21:21:24.202Z] 21:21:24     INFO - TEST-START | browser/components/preferences/in-content/tests/browser_privacypane.js
[task 2018-02-15T21:21:24.223Z] 21:21:24     INFO - TEST-INFO | started process screentopng
[task 2018-02-15T21:21:24.669Z] 21:21:24     INFO - TEST-INFO | screentopng: exit 0
[task 2018-02-15T21:21:24.670Z] 21:21:24     INFO - Buffered messages logged at 21:21:24
[task 2018-02-15T21:21:24.670Z] 21:21:24     INFO - Entering test bound testBrowserErrorInitialValue
[task 2018-02-15T21:21:24.670Z] 21:21:24     INFO - Leaving test bound testBrowserErrorInitialValue
[task 2018-02-15T21:21:24.670Z] 21:21:24     INFO - Entering test bound testBrowserErrorLearnMore
[task 2018-02-15T21:21:24.670Z] 21:21:24     INFO - Leaving test bound testBrowserErrorLearnMore
[task 2018-02-15T21:21:24.672Z] 21:21:24     INFO - Buffered messages finished
[task 2018-02-15T21:21:24.674Z] 21:21:24     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_privacypane.js | This test contains no passes, no fails and no todos. Maybe it threw a silent exception? Make sure you use waitForExplicitFinish() if you need it. -

Comment 1

[Osmose [:osmose, :mkelly]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a90fae87995c322dc52d9cc67bfd9533fe82e509

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

> skip-if = nightly_build
This would skip it on Nightly, not on beta etc. Did you mean:
> run-if = nightly_build

To run it as beta on Try, apply the 3 top most patches from https://treeherder.mozilla.org/#/jobs?repo=try&revision=5266d0c131df0282329576170f7fbb24f482c443&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable
The backout is for hiding another permafail for the Try push.

Comment 3

[Osmose [:osmose, :mkelly]]

Hrm, I _think_ I tried that correctly: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc1afe3d70a131e2022bc470b0b78a695fc95cee&selectedJob=162731903

But it's getting a bunch of build failures. Do I need to include more patches from the linked build? Maybe that inbound merge or something?

The patch is pretty simple so I'll probably put it up for review anyway.

Comment 4

[Phabricator Automation]

Attachment: Bug 1438693: Skip browser_privacypane.js if not a Nightly build.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The bustage is from bug 1435369, filed it as bug 1439004.

Comment 6

[Intermittent Failures Robot]

56 failures in 685 pushes (0.082 failures/push) were associated with this bug in the last 7 days. 

This is the #19 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* try: 56

Platform breakdown:
* linux64-stylo-disabled: 8
* linux64: 6
* windows7-32: 5
* windows10-64: 4
* osx-10-10: 4
* linux32-stylo-disabled: 4
* linux32: 4
* linux64-devedition: 3
* windows7-32-nightly: 2
* windows7-32-devedition: 2
* windows10-64-nightly: 2
* windows10-64-devedition: 2
* macosx64-nightly: 2
* macosx64-devedition: 2
* linux64-nightly: 2
* linux32-nightly: 2
* linux32-devedition: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1438693&startday=2018-02-12&endday=2018-02-18&tree=all

Comment 7

[Intermittent Failures Robot]

24 failures in 126 pushes (0.19 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* try: 24

Platform breakdown:
* linux64: 4
* windows10-64-devedition: 2
* windows10-64: 2
* osx-10-10: 2
* macosx64-devedition: 2
* linux64-stylo-disabled: 2
* linux64-devedition: 2
* linux32-stylo-disabled: 2
* linux32-devedition: 2
* linux32: 2
* windows7-32-devedition: 1
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1438693&startday=2018-02-20&endday=2018-02-20&tree=all

Comment 8

[Osmose [:osmose, :mkelly]]

Gijs: Any idea if you'll be able to review this soon, given the failures? It should be a very quick review.

Comment 9

[:Gijs (out for now; he/him)]

(In reply to Michael Kelly [:mkelly,:Osmose] from comment #8)
> Gijs: Any idea if you'll be able to review this soon, given the failures? It
> should be a very quick review.

Uh, I would have reviewed it within 24 hours of it appearing if I'd had any idea it existed. Until you needinfo'd me I was CC'd on neither this nor the blocking bug, and there's no review request on the attachment here (so it doesn't show up in my bugzilla requests page), and this is the entire email I had from Phabricator about this request:


----
phab-bot changed the visibility from "Administrators" to "Public (No Login Required)".
phab-bot changed the edit policy from "Administrators" to "All Users".

REPOSITORY
rMOZILLACENTRAL mozilla-central

REVISION DETAIL
https://phabricator.services.mozilla.com/D589

EMAIL PREFERENCES
https://phabricator.services.mozilla.com/settings/panel/emailpreferences/

To: Osmose, Gijs
----

I did not deduce from that that I needed to review anything. :-\


Are there bugs on file for making phabricator usable for reviewers so this doesn't happen?

Comment 10

[Phabricator Automation]

Comment on attachment 8951757 [details]
Bug 1438693:  Skip browser_privacypane.js if not a Nightly build.

:Gijs has approved the revision.

https://phabricator.services.mozilla.com/D599

Comment 11

[Osmose [:osmose, :mkelly]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/71cb2d1f1941c884bc6bbaf16f822fcb3b62b77c
Bug 1438693:  Skip browser_privacypane.js if not a Nightly build. r=Gijs

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/71cb2d1f1941

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified with latest uplift simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=05a4f31a247ede629bc8dd714d2c32563a8fadba&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable

Comment 14

[Intermittent Failures Robot]

24 failures in 675 pushes (0.036 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* try: 24

Platform breakdown:
* linux64: 4
* windows10-64-devedition: 2
* windows10-64: 2
* osx-10-10: 2
* macosx64-devedition: 2
* linux64-stylo-disabled: 2
* linux64-devedition: 2
* linux32-stylo-disabled: 2
* linux32-devedition: 2
* linux32: 2
* windows7-32-devedition: 1
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1438693&startday=2018-02-19&endday=2018-02-25&tree=all