1438700 - De-duplicate XPTI string data

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Andrew McCreight [:mccr8]]

It looks like this would be easy to do. I think it would reduce the amount of memory needed by about 35kb.

Comment 1

[Andrew McCreight [:mccr8]]

necko.xpt goes from 42516 bytes to 40100 bytes with this patch.

Comment 2

[Andrew McCreight [:mccr8]]

Oh right, this only reduces disk space, not memory, because we'll reduplicate it as we read it in. It'll still be nice for bug 1438688 though, because then it will reduce both.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1438700, part 1 - Do writing of XPT names to a file via a helper class.

The name of this class is wrong, but my next patch will make it
actually cache. This patch should not change the behavior.

Review commit: https://reviewboard.mozilla.org/r/220958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220958/

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1438700, part 2 - Deduplicate XPT strings.

Various strings, like nsISupports, appear many times in XPT data. This
patch adds a cache so we don't write the same string multiple times.

Review commit: https://reviewboard.mozilla.org/r/220960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220960/

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8951662 [details]
Bug 1438700, part 1 - Do writing of XPT names to a file via a helper class.

https://reviewboard.mozilla.org/r/220958/#review227286

::: commit-message-d70a4:3
(Diff revision 1)
> +Bug 1438700, part 1 - Do writing of XPT names to a file via a helper class. r=glandium
> +
> +The name of this class is wrong, but my next patch will make it

You /could/ not put Cached in the name in this patch and add it in next.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8951663 [details]
Bug 1438700, part 2 - Deduplicate XPT strings.

https://reviewboard.mozilla.org/r/220960/#review227290

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/961d5d58bab7
part 1 - Do writing of XPT names to a file via a helper class. r=glandium
https://hg.mozilla.org/integration/autoland/rev/1f4e9b5602ae
part 2 - Deduplicate XPT strings. r=glandium

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/961d5d58bab7
https://hg.mozilla.org/mozilla-central/rev/1f4e9b5602ae