1438747 - Add missing UPDATE_DOWNLOAD_CODE_UNKNOWN telemetry histogram

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement, P2)

Description

[Robert Strong (they/them - no direct email)]

This was missed when adding the histograms in bug 1137447.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Hi Rebecca, this adds the missing UPDATE_DOWNLOAD_CODE_UNKNOWN histogram that covers the case when the patch type is unknown for the download code and should have been added in bug 1137447. I also added bug numbers for all of the app update histograms. Thanks!

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 8951500 [details] [diff] [review]
patch rev1

Changing review to chutten

Comment 3

[Chris H-C :chutten]

Comment on attachment 8951500 [details] [diff] [review]
patch rev1

Review of attachment 8951500 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for adding bug_numbers in.

I don't suppose these underwent Data Collection Review in bug 1137447? I looked around but didn't see it.

I'd grandfather them in, but they're non-expiring -and- opt-out. Could you run through the process at https://wiki.mozilla.org/Firefox/Data_Collection ? I can be the Data Steward and get you a (supposing I can stop needing days off for annoying head colds) quick turn-around on the review.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: data collection review request

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: unbitrotted patch

I'll put this up on mozphab after the data collection review

Comment 6

[Chris H-C :chutten]

Comment on attachment 9014957 [details]
data collection review request

Preliminary note:

At some point in the future you may be interested to convert the enumerated histograms to categorical ones. That way the labels are part of the probe, and extending them after the fact becomes easier, like for DEVTOOLS_ENTRY_POINT: https://mzl.la/2OIYynd

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? 

Yes. Standard Telemetry mechanisms apply.

    Is there a control mechanism that allows the user to turn the data collection on and off? 

Yes. Standard Telemetry mechanisms apply.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :rstrong.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1

    Is the data collection request for default-on or default-off?

Default on

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No, this is permanent collection.

---
Result: datareview+

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: Bug 1438747 - Add missing app update UPDATE_DOWNLOAD_CODE_UNKNOWN telemetry histogram and missing bug numbers. r?bytesized,chutten

The addition of UPDATE_DOWNLOAD_CODE_UNKNOWN was missed in bug 1137447
Passed data collection review

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ed28d8b07df
Add missing app update UPDATE_DOWNLOAD_CODE_UNKNOWN telemetry histogram and missing bug numbers. r=chutten,bytesized

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/9ed28d8b07df