1438771 - 9.24 - 9.84% build times (windows2012-32, windows2012-64) regression on push 19f8463d3f9d74bfd5ab9f20a38de37107bd726a (Thu Feb 15 2018)

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Ionuț Goldan [:igoldan]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=19f8463d3f9d74bfd5ab9f20a38de37107bd726a

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

 10%  build times windows2012-32 opt static-analysis taskcluster-c4.4xlarge     2,154.93 -> 2,367.07
  9%  build times windows2012-32 opt taskcluster-c4.4xlarge                     2,328.21 -> 2,546.68
  9%  build times windows2012-64 opt static-analysis taskcluster-c4.4xlarge     2,279.62 -> 2,490.34


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=11593

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

Comment 1

[Ionuț Goldan [:igoldan]]

:rillian Build times have noticeably increased on Windows platforms. If the caching system kicks in and resolves this, I'll close this bug.
Are there any concerns about this issue?

Comment 2

[Ionuț Goldan [:igoldan]]

It looks like this regression holds. The build times didn't reduce at all.

Comment 3

[Ralph Giles (:rillian)]

This is unfortunate, but I think we have to accept it for now.

Comment 4

[Ionuț Goldan [:igoldan]]

It seems the build times have improved quite a lot.
Since March 10, the baselines are better even than those before bug 1430885 landed.

The thing is Perfherder doesn't have a clear changeset that brought this improvement. It's likely some change outside of the tree improved our build times; some infra change.
:gps Do you know something about this?

Comment 5

[Gregory Szorc [:gps]]

The original regressions were minor. Nothing that should jeopardize our Rust toolchain update IMO. And it looks like we cancelled them out from upgrading MSVC.

I don't think there's anything actionable here.