Closed Bug 1438796 Opened 8 years ago Closed 1 year ago

Re-Enable test_ext_contentscript_triggeringPrincipal.js on Windows Debug

Categories

(Core :: DOM: Security, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
139 Branch
Tracking Status
firefox139 --- fixed

People

(Reporter: ckerschb, Assigned: robwu)

References

Details

(Whiteboard: [addons-jira])

Attachments

(1 external file)

No description provided.
Priority: -- → P3
Whiteboard: [domsecurity-backlog1]
Kris, do you have any suggestions what might be wrong with the test on windows debug? I tried to increase the timeout, but it still didn't work. If you have any insights, please let me know. thanks!
Flags: needinfo?(kmaglione+bmo)

Let me know if you need more help from DOM Core team.

Flags: needinfo?(kmaglione+bmo)
Severity: normal → S3

As mentioned in bug 1408193, the test interaction with httpd results in
a deadlock, which causes the test to fail intermittently. I observed
this test failure consistently on debug builds.

This patch works around the issue by replacing the use of httpd with a
webRequest.onBeforeRequest listener to extract the relevant request body
from the request.

Along with that, fixes an issue in the ExtensionTestUtils test utility;
it modifies the input manifest, but because the test reuses the
EXTENSION_DATA input between test tasks, the special behavior of merging
host_permissions with permissions for MV2 causes a test failure in the
MV3 test (because in MV3, permissions may not contain host permissions).

Assignee: nobody → rob
Status: NEW → ASSIGNED
See Also: → 1408193
Whiteboard: [domsecurity-backlog1] → [addons-jira]
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/c4da70ccf221 Work around httpd deadlock in test_ext_contentscript_triggeringPrincipal.js r=zombie
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch

FYI: Re-enabling the test exposed a pre-existing issue at bug 1940852.

See Also: → 1940852
QA Whiteboard: [qa-triage-done-c140/b139]
See Also: → 2000636
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: