1438846 - many border-radius tests fail to run on new windows 10 hardware, need fuzzy-if to pass

Status: NEW

(Core :: Layout, defect, P3)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

you can see many failures when on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=38d33764c8fcb54a270518d63f2b596a4f4dde30&filter-searchStr=reftest

we are getting new hardware to run windows 10 tests on and the tests are failing.

here are the fuzzy-if statements I used to get the tests to pass:
-fuzzy-if(skiaContent,17,62) fuzzy-if(webrender,41-41,66-66) == clipping-3.html clipping-3-ref.xhtml # edge of border-radius clips an underlying object's background
+fuzzy-if(/^Windows\x20NT\x2010\.0/.test(http.oscpu),1,1) fuzzy-if(skiaContent,17,62) fuzzy-if(webrender,41-41,66-66) == clipping-3.html clipping-3-ref.xhtml # edge of 

-fuzzy-if(true,1,7) fuzzy-if(d2d,55,94) fuzzy-if(cocoaWidget,1,99) fuzzy-if(Android,99,115) fuzzy-if(skiaContent,1,77) == clipping-5-refc.html clipping-5-ref.html # bug+fuzzy-if(true,1,7) fuzzy-if(d2d,55,95) fuzzy-if(cocoaWidget,1,99) fuzzy-if(Android,99,115) fuzzy-if(skiaContent,1,77) == clipping-5-refc.html clipping-5-ref.html # bug 

-fuzzy-if(true,1,33) fuzzy-if(d2d,59,350) fuzzy-if(cocoaWidget,1,332) fuzzy-if(Android,124,440) fuzzy-if(skiaContent,1,135) fuzzy-if(d3d11&&advancedLayers,59,353) == in+fuzzy-if(true,1,33) fuzzy-if(d2d,59,350) fuzzy-if(cocoaWidget,1,332) fuzzy-if(Android,124,440) fuzzy-if(skiaContent,1,135) fuzzy-if(d3d11&&advancedLayers,81,353) == in

-fuzzy-if(/^Windows\x20NT\x2010\.0/.test(http.oscpu)||/^Windows\x20NT\x206\.2/.test(http.oscpu),1,20) fuzzy-if(d2d,64,157) fuzzy-if(Android,166,400) fuzzy-if(skiaConten+fuzzy-if(/^Windows\x20NT\x2010\.0/.test(http.oscpu)||/^Windows\x20NT\x206\.2/.test(http.oscpu),1,20) fuzzy-if(d2d,98,157) fuzzy-if(Android,166,400) fuzzy-if(skiaConten

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add fuzzy-if to get reftests green

Comment 2

[Jet Villegas (inactive)]

[ Triage 2017/02/20: P3 ]

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8951603 [details] [diff] [review]
add fuzzy-if to get reftests green

I would like to fuzzy-if and leave this open until there are dev cycles to look into this

Comment 4

[Geoff Brown [:gbrown] (pto Jul 1-19)]

Comment on attachment 8951603 [details] [diff] [review]
add fuzzy-if to get reftests green

Review of attachment 8951603 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/border-radius/reftest.list
@@ +49,5 @@
>  == clipping-5-canvas.html clipping-5-refc.html
>  fuzzy-if(/^Windows\x20NT\x206\.2/.test(http.oscpu),1,5) == clipping-5-image.html clipping-5-refi.html
>  fuzzy-if(/^Windows\x20NT\x206\.2/.test(http.oscpu),1,5) fuzzy-if(skiaContent,1,77) == clipping-5-overflow-hidden.html clipping-5-ref.html
>  fuzzy-if(/^Windows\x20NT\x206\.2/.test(http.oscpu),1,5) fuzzy-if(Android,5,21) fuzzy-if(skiaContent,1,97) == clipping-5-refi.html clipping-5-ref.html
> +fuzzy-if(true,1,7) fuzzy-if(d2d,55,95) fuzzy-if(cocoaWidget,1,99) fuzzy-if(Android,99,115) fuzzy-if(skiaContent,1,77) == clipping-5-refc.html clipping-5-ref.html # bug 732535

I'd usually prefer to see a Windows 10-specific fuzzy-if added, rather than modifying an existing fuzzy-if. That would be easier to "untangle" when/if there is additional investigation into this bug, or other related bugs. 

On the other hand, this is a good example of how complicated and un-readable that rule can make a manifest. Maybe it's best like this?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

in this case I am changing fuzzy-if(d2d,55,94) -> fuzzy-if(d2d,55,95); 1 pixel difference and d2d is restricted to windows for the most part.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/352353d90060
many border-radius tests fail to run on new windows 10 hardware. r=gbrown

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aad76c5c2995
fix accidental fuzzy-if change in clipping-3 test. r=me, a=testonly

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?