Closed Bug 1438911 Opened 3 years ago Closed 3 years ago

Consider not doing charset changes off a runnable.

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

So I was looking at the full-doc restyles that stylo-chrome does, and the first one is the one posted from the charset runnable.

This runnable was added in bug 703133. Gecko used to do a sync style reconstruct here, and this used to run out of an observer topic and what not.

Now style reconstructs, at least for stylo, are async.

Annoying bits here are multiple, but in chrome at least when the charset changes we don't have any frame or any style, so a PostRebuildAllStyleDataEvent would boil down to nothing, as it should.

I think we can try to make it use other mechanism that doesn't defer this to the next event loop bit, where we'd actually have style data and we'd need to restyle the whole thing.
So this is probably harmless for stylo-chrome, I guess, because the document is resource://gre-resources/hiddenWindow.html, which is basically empty.

But it may be worth doing for normal content docs.
No longer blocks: 1420423
Comment on attachment 8951706 [details]
Bug 1438911: Avoid doing changeset changes off a runnable for stylo.

https://reviewboard.mozilla.org/r/220982/#review227260
Attachment #8951706 - Flags: review?(bzbarsky) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f21e0c72bebf
Avoid doing changeset changes off a runnable for stylo. r=bz
[ Triage 2017/02/20: P3 ]
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/f21e0c72bebf
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Depends on: 1511570
Blocks: 1511570
No longer depends on: 1511570
You need to log in before you can comment on or make changes to this bug.