1439023 - Selection of previously entered form history data broken in Nightly when Form Autofill is enabled

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Albert Scheiner [:alberts]]

Attachment: form-field-filling-issue.ogv

Data I have previously entered in similar fields, like my last name, still appears in a dropdown underneath the corresponding input field, but when I make a selection it does not translate into the input field value anymore. Filling out forms, especially email fields became much more tedious again with this bug.
Please see the video attached.

Maybe I have time after the weekend to find a regression range.

Comment 1

[Matthew N. [:MattN]]

(In reply to Albert Scheiner [:alberts] from comment #0)
> Maybe I have time after the weekend to find a regression range.

That would be awesome!

Comment 2

[Albert Scheiner [:alberts]]

I have created a test case with steps to reproduce the issue and found the following regression:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3eeb832ace97ae24cfeb3db0cbcdbc3390b1f304&tochange=0fd485f3f388f4fdd9044aa6598245e511a4179a

Comment 3

[Matthew N. [:MattN]]

Un-duping since it seems like the login form issue of bug 1437791 is resolved but this isn't.

Comment 4

[Matthew N. [:MattN]]

Attachment: Bug 1439023 - Don't reset autocomplete controller state when autofill fell back to form history. r=jaws

Otherwise the cached value won't be used for filling by satchel and _fillFromAutocompleteRow won't fill a result that isn't a autofill-profile style:
https://searchfox.org/mozilla-central/rev/03ebbdab952409640c6857d835d3040bf6f9e2db/browser/extensions/formautofill/FormAutofillContent.jsm#283,295

Comment 5

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Albert, do you have that test case handy? Once the patch lands I'd love for us to be able to verify the fix and possibly uplift to beta.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/047455dcfc20
Don't reset autocomplete controller state when autofill fell back to form history. r=jaws

Comment 7

[Matthew N. [:MattN]]

(In reply to Liz Henry (:lizzard) (use needinfo) from comment #5)

Albert, do you have that test case handy? Once the patch lands I'd love for us to be able to verify the fix and possibly uplift to beta.

It's in the URL field.

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/047455dcfc20

Comment 9

[Albert Scheiner [:alberts]]

It is already working for me! Thanks 🙌

Comment 10

[Gyula Palko[:gpalko]]

Verified on Nightly 67(20190214044118), that the issue is not reproducing, using the attached testcase.

Comment 11

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Matt, do you want to request beta uplift?

Comment 12

[Matthew N. [:MattN]]

Let's give it a week or two to bake first. I'll leave the needinfo as a reminder.

Comment 13

[Matthew N. [:MattN]]

Comment on attachment 9042689 [details]
Bug 1439023 - Don't reset autocomplete controller state when autofill fell back to form history. r=jaws

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1429718

User impact if declined

Form history (and saved logins?) won't fill when the field was handled by Form Autofill.

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

Yes

If yes, steps to reproduce

1. Set browser.search.region = "US" and restart an en-US Firefox.
2. Use test page at https://codepen.io/scheinercc/full/mXawWz/ which has STR

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

This returns to the previous behaviour for autocomplete popups not from Form Autofill.

String changes made/needed

None

Comment 14

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 9042689 [details]
Bug 1439023 - Don't reset autocomplete controller state when autofill fell back to form history. r=jaws

Fix for form autofill, verified in Nightly.
OK to uplift for beta 11.

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e69dd7ef8878

Comment 16

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c6abdbd324f7

Comment 17

[Gyula Palko[:gpalko]]

Verified on Beta 66(20190228180200), that the issue is not reproducing, using the attached testcase. Tested on Windows 10 x64, MacOS 10.12 and Ubuntu 16.04