1439076 - csrc-audio-level support is not offered

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

The csrc-audio-level header support is not offered.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1439076 - P1 - negotiate csrc-audio-level RTP header

Review commit: https://reviewboard.mozilla.org/r/221130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221130/

Comment 2

[Michael Froman [:mjf]]

Comment on attachment 8951839 [details]
Bug 1439076 - P1 - negotiate csrc-audio-level RTP header

https://reviewboard.mozilla.org/r/221130/#review227682

Looks good to me.

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8951839 [details]
Bug 1439076 - P1 - negotiate csrc-audio-level RTP header

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221130/diff/1-2/

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1439076 - P2 - csrc-audio-level jsep gtest fixes

Review commit: https://reviewboard.mozilla.org/r/221834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221834/

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8951839 [details]
Bug 1439076 - P1 - negotiate csrc-audio-level RTP header

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221130/diff/2-3/

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8952584 [details]
Bug 1439076 - P2 - csrc-audio-level jsep gtest fixes

https://reviewboard.mozilla.org/r/221834/#review227722

lgtm

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8951839 [details]
Bug 1439076 - P1 - negotiate csrc-audio-level RTP header

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221130/diff/3-4/

Comment 8

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8952584 [details]
Bug 1439076 - P2 - csrc-audio-level jsep gtest fixes

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221834/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/337513e93e5f
P1 - negotiate csrc-audio-level RTP header r=mjf
https://hg.mozilla.org/integration/autoland/rev/70e645dff837
P2 - csrc-audio-level jsep gtest fixes r=jib

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/337513e93e5f
https://hg.mozilla.org/mozilla-central/rev/70e645dff837

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Since we're getting close to 59 release (March 13) I'd keep this change in 60, unless there is a strong argument for pushing the change to 59.