1439194 - Different sync illustrations in sync reauth state

Status: RESOLVED FIXED

Description

[magicp]

Attachment: different-sync-illustrations-in-sync-reauth-state.png

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 ID:20180217220052

Steps to reproduce:
1. Launch Nightly with sync reauth state
2. Open synced tabs sidebar and synced tabs in library


Actual results:
Different sync illustrations in sync reauth state.


Expected results:
Which sync illustration is correct?

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1439194 - Implement a separate state for login failed in the sidebar.

Review commit: https://reviewboard.mozilla.org/r/221514/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221514/

Comment 2

[Mark Hammond [:markh]]

Comment on attachment 8952271 [details]
Bug 1439194 - Implement a separate state for login failed in the sidebar.

https://reviewboard.mozilla.org/r/221514/#review227306

thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab4200b42614
Implement a separate state for login failed in the sidebar. r=markh

Comment 4

[Andrei Ciure[:andrei_ciure]]

https://hg.mozilla.org/mozilla-central/rev/ab4200b42614

Comment 5

[Liz Henry (:lizzard) (use needinfo)]

Is this a new regression in 59? 
Is it a common enough situation that we might want to uplift the fix, or can this wait to release with 60?

Comment 6

[Edouard Oger [:eoger]]

The bug has always been there (but I suspect we discovered it because we changed the illustration).
I don't believe this warrants an uplift since the button still does what we want.

Comment 7

[Liz Henry (:lizzard) (use needinfo)]

OK, thanks Edouard!