1439279 - Drop needless requestAnimationFrame in reftests for animations

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

There are lots of unnecessary requestAnimationFrame in reftests for animations.  I am suspecting it's one of the reasons that some reftests fail on WebRender.  That's because if there is an unnecessary requestAnimationFrame, there are cases that we wait for a MozAfterPaint for the paint that no invalidation changes happened. (e.g. both from and to keyframes are the same value).

We should drop requestAnimationFrame to get a MozAfterPaint event for the case where invalidation changes happen (i.e. right after style changes happen).

Comment 1

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5060299683593c035fa2e1492c441713bcd8d455

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1439279 - Drop needless requestAnimationFrame that waits for applying new transition.

getComputedStyle() ensures triggering new transitions, so we don't need to wait
for a requestAnimationFrame callback.

Review commit: https://reviewboard.mozilla.org/r/221264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221264/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1439279 - Append animating element after animation gets ready.

This test is supposed to append *animating* element to the document.

Review commit: https://reviewboard.mozilla.org/r/221266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221266/

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1439279 - Drop needless requestAnimationFrame in reftest for web-animation.

Refrests without specifing reftest-no-flush flush all pending styles so that
we don't need to wait for a requestAnimationFrame to apply the final style
changes.

Review commit: https://reviewboard.mozilla.org/r/221268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221268/

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Brian, any chance of reviewing?

Comment 6

[Brian Birtles (:birtles)]

Comment on attachment 8952042 [details]
Bug 1439279 - Drop needless requestAnimationFrame that waits for applying new transition.

https://reviewboard.mozilla.org/r/221264/#review227114

Comment 7

[Brian Birtles (:birtles)]

Comment on attachment 8952043 [details]
Bug 1439279 - Append animating element after animation gets ready.

https://reviewboard.mozilla.org/r/221266/#review227116

Comment 8

[Brian Birtles (:birtles)]

Comment on attachment 8952044 [details]
Bug 1439279 - Drop needless requestAnimationFrame in reftest for web-animation.

https://reviewboard.mozilla.org/r/221268/#review227118

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Thank you for the quick reviews!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b37d7ac91008
Drop needless requestAnimationFrame that waits for applying new transition. r=birtles
https://hg.mozilla.org/integration/autoland/rev/04c3f7e2f6fe
Append animating element after animation gets ready. r=birtles
https://hg.mozilla.org/integration/autoland/rev/fc7f1c7fb157
Drop needless requestAnimationFrame in reftest for web-animation. r=birtles

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b37d7ac91008
https://hg.mozilla.org/mozilla-central/rev/04c3f7e2f6fe
https://hg.mozilla.org/mozilla-central/rev/fc7f1c7fb157