1439355 - use static_assert instead of NS_ASSERTION in nsBinaryStream.cpp

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Nathan Froyd [:froydnj]]

The intention is a little more clear with static_assert, as well as
failing sooner.  (The code is probably the same, since the compiler will
optimize out the checks as dead code, but meh.)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use static_assert instead of NS_ASSERTION in nsBinaryStream.cpp

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8952119 [details] [diff] [review]
use static_assert instead of NS_ASSERTION in nsBinaryStream.cpp

Review of attachment 8952119 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/io/nsBinaryStream.cpp
@@ +201,1 @@
>                 "False assumption about sizeof(float)");

nit: fix indentation of string here and below.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0586b21d0709
use static_assert instead of NS_ASSERTION in nsBinaryStream.cpp; r=mystor

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/0586b21d0709