Closed
Bug 1439365
Opened 7 years ago
Closed 7 years ago
Add a MinGW Opt Build
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor])
Attachments
(1 file)
Tor's MinGW build uses --enable-optimize, so it'd be good to actually build that particular configuration.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8952123 [details]
Bug 1439365 Add a MinGW Opt Build
https://reviewboard.mozilla.org/r/221358/#review227300
::: browser/config/mozconfigs/win32/mingw32-debug:4
(Diff revision 1)
> +. "$topsrcdir/browser/config/mozconfigs/win32/mingw32"
> +
> +ac_add_options --enable-debug
> +ac_add_options --disable-optimize
I hadn't realized these builds were without optimizations. The other debug builds *are* optimized, are you sure you want these not to be?
::: taskcluster/ci/build/windows.yml:648
(Diff revision 1)
> + description: "Win32 MinGW Opt"
> + index:
> + product: firefox
> + job-name: win32-mingw32-opt
> + treeherder:
> + platform: windows-mingw32-32/opt
platforms with one job contribute to making treeherder horrible to watch at. This feels like we should use the same "platform" for mingw32 opt and debug builds.
Attachment #8952123 -
Flags: review?(mh+mozilla) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #3)
> Comment on attachment 8952123 [details]
> Bug 1439365 Add a MinGW Opt Build
>
> https://reviewboard.mozilla.org/r/221358/#review227300
>
> ::: browser/config/mozconfigs/win32/mingw32-debug:4
> (Diff revision 1)
> > +. "$topsrcdir/browser/config/mozconfigs/win32/mingw32"
> > +
> > +ac_add_options --enable-debug
> > +ac_add_options --disable-optimize
>
> I hadn't realized these builds were without optimizations. The other debug
> builds *are* optimized, are you sure you want these not to be?
Yea, it's tough enough to debug MinGW builds as it is, optimizing them makes it even harder. No one's running these for none-testing/debugging purposes.
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b33237dcbabf
Add a MinGW Opt Build r=glandium
Keywords: checkin-needed
Comment 7•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/7295cf324a43a0d1883d514da4ffb77b2968ef4a
Bug 1439365 - Add Windows MinGW to platformMap (#3242)
Comment 8•7 years ago
|
||
Backed out for failing mochitest at browser/components/resistfingerprinting/test/mochitest/test_animation_api.html
Push that contains the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d32d276d2917d39471d8aa45192436f8819c5df0
failure log: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d32d276d2917d39471d8aa45192436f8819c5df0
Backout: https://hg.mozilla.org/integration/autoland/rev/136296cea37a772545863c9531193f466246eebf
Flags: needinfo?(tom)
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c45d8cec7d8
Add a MinGW Opt Build r=glandium
Comment 10•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(tom)
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•