1439418 - Policy engine - Properly support optional and required fields in the schema

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement)

Description

[:Felipe Gomes (needinfo for replies!)]

The situation for properties inside an object was a bit messy: all properties were required, except for the ugly exception added in bug 1433271 for arrays.

The correct way to do is to make all fields optional, and only require the ones marked as required, following what json-schema.org does.

I attempted to do this in bug 1433271 but I think I started in the wrong direction there, and it seemed much more complicated than it actually is. I now removed the workaround added there, and the test added continues to pass.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1439418 - Policy engine - Properly support optional and required fields in the schema.

Review commit: https://reviewboard.mozilla.org/r/221468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221468/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8952213 [details]
Bug 1439418 - Policy engine - Properly support optional and required fields in the schema.

https://reviewboard.mozilla.org/r/221468/#review227670

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23c051322140
Policy engine - Properly support optional and required fields in the schema. r=mossop

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/23c051322140