1439437 - Tests for block autoplay gesture activation

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We don't have tests for whether user-gesture enables autoplay in documents or in iframes inside documents.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1439437 - Tests for autoplay gesture activation in new windows/frames.

Autoplay of audible media should be blocked in documents until they have a user
gesture in them, or in a same-origin parent document. This patch adds tests for
those cases.

Review commit: https://reviewboard.mozilla.org/r/221496/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221496/

Comment 2

[u480271]

Comment on attachment 8952252 [details]
Bug 1439437 - Tests for autoplay gesture activation in new windows/frames.

https://reviewboard.mozilla.org/r/221496/#review228084

::: dom/media/test/mochitest.ini:443
(Diff revision 1)
>    dynamic_resource.sjs
>    eme.js
>    file_access_controls.html
> +  file_autoplay_policy_activation_window.html
> +  file_autoplay_policy_activation_frame.html
> +  file_blank.html

What is `file_blank.html`? I can't see it added in this patch or being referenced.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8952252 [details]
Bug 1439437 - Tests for autoplay gesture activation in new windows/frames.

https://reviewboard.mozilla.org/r/221496/#review228102

::: dom/media/test/mochitest.ini:443
(Diff revision 1)
>    dynamic_resource.sjs
>    eme.js
>    file_access_controls.html
> +  file_autoplay_policy_activation_window.html
> +  file_autoplay_policy_activation_frame.html
> +  file_blank.html

D'oh! Leftovers from bad decisions, since removed. Thanks!

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8952252 [details]
Bug 1439437 - Tests for autoplay gesture activation in new windows/frames.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221496/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23605d8d11e9
Tests for autoplay gesture activation in new windows/frames. r=kamidphish

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/23605d8d11e9