Closed Bug 1439452 Opened 2 years ago Closed 2 years ago

In About:preferences the "Find in Option" search field should have min width of 15.4em

Categories

(Firefox :: Preferences, defect)

60 Branch
Unspecified
Windows
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 60
Tracking Status
firefox60 --- verified

People

(Reporter: StefanG_QA, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 (20180219100221)

STR:
1. Open Nightly with Italian locale
2. Navigate to about:preferences#sync
3. Verify "Find in Options" search box has a min width of 15.4em 

AR: The min width is set to 16em ("min-width: 16em")
ER: The min width should have min-width of 15.4em
Flags: needinfo?(gandalf)
This bug is a result of change from `width` to `min-width` in bug 1424682. Taking
Assignee: nobody → gandalf
Blocks: 1424682
Status: NEW → ASSIGNED
Flags: needinfo?(gandalf)
flod: it's a minor issue, but I'm not entirely sure how to fix it across all localizations tbh. :(
Comment on attachment 8953353 [details]
Bug 1439452 - Use `width` instead of `min-width` for `Find in Preferences` box.

https://reviewboard.mozilla.org/r/222650/#review228544

You need a new string ID at this point.
1) Pontoon will not force localizers to retranslate
2) Migration code will ignore the string, because it's already in the FTL file
Attachment #8953353 - Flags: review?(francesco.lodolo) → review-
(In reply to Stefan [:StefanG_QA] from comment #0)
> AR: The min width is set to 16em ("min-width: 16em")
> ER: The min width should have min-width of 15.4em

Note that the bug report is imprecise:
ER: The min width should have **width** of 16em

The value is going to change, since that's the very reason to have it localizable.
> You need a new string ID at this point.

/me raises fist to the sky - semantic comments, we need you

> 2) Migration code will ignore the string, because it's already in the FTL file

What's the purpose of storing the migration scripts then in tree if we don't have a use for them later?

Updated the patch.
(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #7)
> > You need a new string ID at this point.
> 
> /me raises fist to the sky - semantic comments, we need you
> 
> > 2) Migration code will ignore the string, because it's already in the FTL file
> 
> What's the purpose of storing the migration scripts then in tree if we don't
> have a use for them later?

That locales might have added translations for strings that we need to migrate. The other way around (overwriting existing strings), we would also risk to lose QA done on the FTL file in the meantime.

I think we need to:
1) Remove the obsolete string from bug_1424682_preferences_chrome.py. In that way, if we re-run the migration we don't reimport a string that was removed by Pontoon.
2) Add migration for this bug (just for this string).

I'd be OK with collapsing the two, and migrating this string reusing bug_1424682_preferences_chrome.py
Comment on attachment 8953353 [details]
Bug 1439452 - Use `width` instead of `min-width` for `Find in Preferences` box.

https://reviewboard.mozilla.org/r/222650/#review228640

Note to self: for this I should run migrations in reversed chronological order, since the first running removes obsolete strings.
Attachment #8953353 - Flags: review?(francesco.lodolo) → review+
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cdfaf636da2f
Use `width` instead of `min-width` for `Find in Preferences` box. r=flod
https://hg.mozilla.org/mozilla-central/rev/cdfaf636da2f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
This bug is verified using latest Nightly and Beta 60.0b12 builds. "Find in Option" has a width of 15.4em.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.