1439452 - In About:preferences the "Find in Option" search field should have min width of 15.4em

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Stefan [:StefanG_QA]]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 (20180219100221)

STR:
1. Open Nightly with Italian locale
2. Navigate to about:preferences#sync
3. Verify "Find in Options" search box has a min width of 15.4em 

AR: The min width is set to 16em ("min-width: 16em")
ER: The min width should have min-width of 15.4em

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

This bug is a result of change from `width` to `min-width` in bug 1424682. Taking

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1439452 - Use `width` instead of `min-width` for `Find in Preferences` box.

Review commit: https://reviewboard.mozilla.org/r/222650/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222650/

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

flod: it's a minor issue, but I'm not entirely sure how to fix it across all localizations tbh. :(

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8953353 [details]
Bug 1439452 - Use `width` instead of `min-width` for `Find in Preferences` box.

https://reviewboard.mozilla.org/r/222650/#review228544

You need a new string ID at this point.
1) Pontoon will not force localizers to retranslate
2) Migration code will ignore the string, because it's already in the FTL file

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Stefan [:StefanG_QA] from comment #0)
> AR: The min width is set to 16em ("min-width: 16em")
> ER: The min width should have min-width of 15.4em

Note that the bug report is imprecise:
ER: The min width should have **width** of 16em

The value is going to change, since that's the very reason to have it localizable.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8953353 [details]
Bug 1439452 - Use `width` instead of `min-width` for `Find in Preferences` box.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222650/diff/1-2/

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

> You need a new string ID at this point.

/me raises fist to the sky - semantic comments, we need you

> 2) Migration code will ignore the string, because it's already in the FTL file

What's the purpose of storing the migration scripts then in tree if we don't have a use for them later?

Updated the patch.

Comment 8

[Francesco Lodolo [:flod]]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #7)
> > You need a new string ID at this point.
> 
> /me raises fist to the sky - semantic comments, we need you
> 
> > 2) Migration code will ignore the string, because it's already in the FTL file
> 
> What's the purpose of storing the migration scripts then in tree if we don't
> have a use for them later?

That locales might have added translations for strings that we need to migrate. The other way around (overwriting existing strings), we would also risk to lose QA done on the FTL file in the meantime.

I think we need to:
1) Remove the obsolete string from bug_1424682_preferences_chrome.py. In that way, if we re-run the migration we don't reimport a string that was removed by Pontoon.
2) Add migration for this bug (just for this string).

I'd be OK with collapsing the two, and migrating this string reusing bug_1424682_preferences_chrome.py

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8953353 [details]
Bug 1439452 - Use `width` instead of `min-width` for `Find in Preferences` box.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222650/diff/2-3/

Comment 10

[Francesco Lodolo [:flod]]

Comment on attachment 8953353 [details]
Bug 1439452 - Use `width` instead of `min-width` for `Find in Preferences` box.

https://reviewboard.mozilla.org/r/222650/#review228640

Note to self: for this I should run migrations in reversed chronological order, since the first running removes obsolete strings.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdfaf636da2f
Use `width` instead of `min-width` for `Find in Preferences` box. r=flod

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cdfaf636da2f

Comment 13

[Stefan [:StefanG_QA]]

This bug is verified using latest Nightly and Beta 60.0b12 builds. "Find in Option" has a width of 15.4em.