1439474 - Make double-free crashes more identifiable

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1439474 - Make double-free crashes more identifiable.

- Turn MOZ_DIAGNOSTIC_ASSERTs related to double-frees into
MOZ_RELEASE_ASSERTs with a crash message making them more identifiable
than the asserted condition.
- In huge_dalloc, MOZ_RELEASE_ASSERT early, instead of letting
RedBlackTree::Remove end up crashing because the node is not in the
tree.

Review commit: https://reviewboard.mozilla.org/r/221530/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221530/

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8952280 [details]
Bug 1439474 - Make double-free crashes more identifiable.

https://reviewboard.mozilla.org/r/221530/#review227334

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f2dd59744eb
Make double-free crashes more identifiable. r=njn

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7f2dd59744eb

Comment 5

[Chris Peterson [:cpeterson]]

glandium, should we uplift these release assertions to Beta 59? The original MOZ_DIAGNOSTIC_ASSERTs are already enabled in Nightly and DevEdition builds, so this change won't catch any new double-free bugs until Nightly 60 rides to Beta on March 12.

Comment 6

[Mike Hommey [:glandium]]

As you mention, the MOZ_RELEASE_ASSERTs replacing the MOZ_DIAGNOSTIC_ASSERTs are not going to catch anything new. The other one is not going to catch anything new either: the rb.h code already crashes when it happens.