Closed Bug 1439503 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 9583 - Add the "dtmf" attribute on RTCRTPSender

Categories

(Core :: WebRTC, enhancement, P3)

Product:
Core
Component:
WebRTC
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 9583 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9583
Details from upstream follow.

Harald Alvestrand wrote:
>  Add the "dtmf" attribute on RTCRTPSender
>  
>  This brings the API into conformance with the spec:
>  https://w3c.github.io/webrtc-pc/#dom-rtcdtmfsender
>  
>  The CL also exposes the RTCDTMFToneChange event, which
>  was previously marked [ NoInterface ].
>  
>  Bug: 812587
>  Change-Id: I4122d1e4e336b811de234ed492f0de02dcc7a714
>  
>  Reviewed-on: https://chromium-review.googlesource.com/926181
>  WPT-Export-Revision: c5f044d53221031cfc2bca29c02cc6e8ba9b84b0
Component: web-platform-tests → WebRTC
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 3 tests and 7 subtests
OK     : 2
PASS   : 1
FAIL   : 6

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/webrtc/RTCDTMFSender-insertDTMF.https.html
    insertDTMF() should set toneBuffer to provided tones normalized, with old tones overridden: FAIL
    insertDTMF() should succeed if tones contains valid DTMF characters: FAIL
    insertDTMF() should throw InvalidCharacterError if tones contains invalid DTMF characters: FAIL
/webrtc/RTCDTMFSender-ontonechange-long.https.html
    insertDTMF with duration greater than 6000 should be clamped to 6000: FAIL

Tests that are disabled for instability:
/webrtc/RTCDTMFSender-ontonechange.https.html
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1915bc95eff2
[wpt PR 9583] - Add the "dtmf" attribute on RTCRTPSender, a=testonly
https://hg.mozilla.org/mozilla-central/rev/1915bc95eff2
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.