1439507 - Add more bits of XBL bindings to memory report

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Xidorn Quan [:xidorn] UTC+10]

I thought the stylesheet lists should have been tracked by somewhere else... but it turns out they are not. So they should come to binding size as well. It is a pretty significant one, almost double the size accumulated in the xul cache.

Prototype handler is another big thing which I overlooked in bug 1438497. DMD shows it has some non-trivial allocation inside.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1439507 - Add more XBL binding stuff to memory report.

Review commit: https://reviewboard.mozilla.org/r/221554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221554/

Comment 2

[Jet Villegas (inactive)]

[ Triage 2017/02/20: P3 ]

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8952308 [details]
Bug 1439507 - Add more XBL binding stuff to memory report.

https://reviewboard.mozilla.org/r/221554/#review227714

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f991fdfb4ca4
Add more XBL binding stuff to memory report. r=njn

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f991fdfb4ca4

Comment 6

[Eric Rahm [:erahm]]

Comment on attachment 8952308 [details]
Bug 1439507 - Add more XBL binding stuff to memory report.

https://reviewboard.mozilla.org/r/221554/#review228094

::: dom/xbl/nsXBLPrototypeHandler.cpp:1149
(Diff revision 1)
> +       handler; handler = handler->mNextHandler) {
> +    n += aMallocSizeOf(handler);
> +    if (!(mType & NS_HANDLER_TYPE_XUL)) {
> +      n += aMallocSizeOf(handler->mHandlerText);
> +    }
> +    n += mHandler ? aMallocSizeOf(handler->mHandler) : 0;

I might be missing something, but this seems incorrect. Should it be:

```
n += handlier->mHandler ? aMallocSizeOf(handler->mHandler) : 0;
```

Also, at least for mozilla, moz_malloc_size_of ends up handling nullptr.

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Ah, good catch. I'll fix it.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1da08053c5d6
followup - Don't do null-check for nsXBLPrototypeHandler::mHandler.

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1da08053c5d6