1439674 - Preserve extension pages across extension updates

Status: NEW

(WebExtensions :: General, enhancement, P3)

Description

[Andrew Swan [:aswan]]

When a webextension is disabled we currently close any tabs that contain its pages.  This is reasonable if the extension is being disabled or uninstalled (which is typically something a user initiates manually), but it isn't so great if the extension is being updated in the background and a bunch of tabs suddenly disappear.  For a successful update, can we just leave the pages there or reload them if necessary?

ni to myself to see what Chrome does here, and cc a few others who might have thoughts...

Comment 1

[Shane Caraveo (:mixedpuppy)]

(In reply to Andrew Swan [:aswan] from comment #0)
> When a webextension is disabled we currently close any tabs that contain its
> pages.

Not always (unless that was fixed).  If the extension page does not use an api, it will be left open.

> For a successful update, can we just leave the
> pages there or reload them if necessary?

Seems like a reload would be proper.  But what if that url is gone in the update?

Comment 2

[Andrew Swan [:aswan]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #1)
> (In reply to Andrew Swan [:aswan] from comment #0)
> > When a webextension is disabled we currently close any tabs that contain its
> > pages.
> 
> Not always (unless that was fixed).  If the extension page does not use an
> api, it will be left open.

That's a distinct (but related) issue.  Is there an open bug for it?

> > For a successful update, can we just leave the
> > pages there or reload them if necessary?
> 
> Seems like a reload would be proper.  But what if that url is gone in the
> update?

The more careful sequence here would be something like:
1. when updating, navigate existing tabs to about:blank
2. apply the update
3. (try to) navigate those existing tabs back to their previous locations

If the update breaks the old pages then they just turn into generic error pages...