Closed Bug 1439763 Opened 4 years ago Closed 4 years ago

Update Debugger Frontend v18

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → jlaster
Priority: -- → P3
Summary: Up → Update Debugger Frontend v18
Attached patch rel18.patchSplinter Review
Attachment #8952561 - Flags: review?(jdescottes)
Severity: normal → enhancement
Status: NEW → ASSIGNED
Comment on attachment 8952561 [details] [diff] [review]
rel18.patch

Review of attachment 8952561 [details] [diff] [review]:
-----------------------------------------------------------------

- Meta:
 - assigned, P3, enhancement, blocks meta: OK
 - commit message: OK
 - less than 20 commits: OK
- TRY
 - try run green: OK, but many failures for the intermittent https://bugzilla.mozilla.org/show_bug.cgi?id=1434868, need to narrow it down 
 - try run has rebuild: OK
- Manual test
 - OK
- README review
 - compare link: OK
 - version number: OK
- Properties file review: N/A
- New files: OK (but are the new example files used?)

::: devtools/client/debugger/new/README.mozilla
@@ +6,2 @@
>  
>  Packages:

I think the information below is outdated? Can we remove it for the next release?

::: devtools/client/debugger/new/test/mochitest/examples/doc-babel.html
@@ +41,5 @@
> +    <button onclick="stepOverForOfClosure()">Run stepOverForOfClosure</button>
> +    <script src="babel/fixtures/step-over-function-params/output.js"></script>
> +    <button onclick="stepOverFunctionParams()">Run stepOverFunctionParams</button>
> +    <script src="babel/fixtures/step-over-regenerator-await/output.js"></script>
> +    <button onclick="stepOverRegeneratorAwait()">Run stepOverRegeneratorAwait</button>

I can't see where these new buttons (and all the new files) are being used? I assumed new test code should be added to browser-dbg-babel.js, but can't see anything there. There's been a lot of new source files added recently so I'd like to make sure we are using them.
Attachment #8952561 - Flags: review?(jdescottes) → review+
No performance improvement nor regression detected.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb629a5223e1
Update Debugger Frontend v18. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/bb629a5223e1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.