1439763 - Update Debugger Frontend v18

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Comment 1

[Jason Laster [:jlast]]

fast: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e733f43b58fc3a56fc6b461c8ed130d2b65b3ec
thorough: https://treeherder.mozilla.org/#/jobs?repo=try&revision=78a3ba7616de508b63c8727142267698fc3e98bb
comparison: http://github.com/devtools-html/debugger.html/compare/release-17...release-18

Comment 2

[Jason Laster [:jlast]]

Attachment: rel18.patch

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8952561 [details] [diff] [review]
rel18.patch

Review of attachment 8952561 [details] [diff] [review]:
-----------------------------------------------------------------

- Meta:
 - assigned, P3, enhancement, blocks meta: OK
 - commit message: OK
 - less than 20 commits: OK
- TRY
 - try run green: OK, but many failures for the intermittent https://bugzilla.mozilla.org/show_bug.cgi?id=1434868, need to narrow it down 
 - try run has rebuild: OK
- Manual test
 - OK
- README review
 - compare link: OK
 - version number: OK
- Properties file review: N/A
- New files: OK (but are the new example files used?)

::: devtools/client/debugger/new/README.mozilla
@@ +6,2 @@
>  
>  Packages:

I think the information below is outdated? Can we remove it for the next release?

::: devtools/client/debugger/new/test/mochitest/examples/doc-babel.html
@@ +41,5 @@
> +    <button onclick="stepOverForOfClosure()">Run stepOverForOfClosure</button>
> +    <script src="babel/fixtures/step-over-function-params/output.js"></script>
> +    <button onclick="stepOverFunctionParams()">Run stepOverFunctionParams</button>
> +    <script src="babel/fixtures/step-over-regenerator-await/output.js"></script>
> +    <button onclick="stepOverRegeneratorAwait()">Run stepOverRegeneratorAwait</button>

I can't see where these new buttons (and all the new files) are being used? I assumed new test code should be added to browser-dbg-babel.js, but can't see anything there. There's been a lot of new source files added recently so I'd like to make sure we are using them.

Comment 4

[Julian Descottes [:jdescottes]]

Talos against v17.0 Talos push: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=311e01be916de42ea9f1e2c2ad991ec8a14309b8&newProject=try&newRevision=b12120663002c2b63f0e6a4df51df7c4b5fcfdfb&framework=1

Comment 5

[Julian Descottes [:jdescottes]]

Some other changes seem to pollute the results. Compare with baseline : https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=047158625a62&newProject=try&newRevision=b12120663002c2b63f0e6a4df51df7c4b5fcfdfb&framework=1 (no results yet)

Comment 6

[Julian Descottes [:jdescottes]]

No performance improvement nor regression detected.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb629a5223e1
Update Debugger Frontend v18. r=jdescottes

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/bb629a5223e1