1439800 - new Date("01-Apr-08") accepted in Chrome but is invalid in Firefox

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect, P3)

Description

[Dietrich Ayala (:dietrich)]

I couldn't find anything to dupe against, but seems like it should be here already...

new Date("01-Apr-08")

Chrome Canary: Tue Apr 01 2008 00:00:00 GMT-0700 (PDT)

Firefox Nightly: Invalid Date

Comment 1

[Tom S. (please needinfo tschuster)]

https://stackoverflow.com/questions/64927043/dash-is-counting-as-substract-in-date-function

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1439800 - Support dd-MMM-yyyy and dd-MMM-yy in Date parsing. r?evilpie!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d89fb9ef55c4
Support dd-MMM-yyyy and dd-MMM-yy in Date parsing. r=evilpie

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The following field has been copied from a duplicate bug:

Field	Value	Source
Webcompat Priority	?	bug 1515318

For more information, please visit auto_nag documentation.

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d89fb9ef55c4

Comment 13

[Takanori MATSUURA]

Hi tooru,
This fixes JAL flight reservation (See bug 1825938).
Do you think we should uplift this pref change to Beta 113, 112 and ESR102?

Comment 14

[Tooru Fujisawa [:arai]]

Comment on attachment 9329964 [details]
Bug 1439800 - Support dd-MMM-yyyy and dd-MMM-yy in Date parsing. r?evilpie!

Beta/Release Uplift Approval Request

• User impact if declined: Users cannot reserve a flight on JAL website (bug 1825938)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This fixes the Date parsing where a dash - before year had been treated as minus sign, only on Firefox (Chrome and Safari don't).
  It's less likely that some website depends on the previous Firefox's behavior.
• String changes made/needed:
• Is Android affected?: Yes

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This issue affects a major website on Japan.
• User impact if declined: Users cannot reserve a flight on JAL website (bug 1825938)
• Fix Landed on Version: 114
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This fixes the Date parsing where a dash - before year had been treated as minus sign, only on Firefox (Chrome and Safari don't).
  It's less likely that some website depends on the previous Firefox's behavior.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9329964 [details]
Bug 1439800 - Support dd-MMM-yyyy and dd-MMM-yy in Date parsing. r?evilpie!

Too late for a 112 dot release at this point.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9329964 [details]
Bug 1439800 - Support dd-MMM-yyyy and dd-MMM-yy in Date parsing. r?evilpie!

Approved for 113.0b9.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/734f99661cb1

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9329964 [details]
Bug 1439800 - Support dd-MMM-yyyy and dd-MMM-yy in Date parsing. r?evilpie!

Approved for 102.11esr.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/a03fde6c49d8