1439812 - Move noscript methods of nsIPlainTextEditor to TextEditor

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

For de-virtualaize....

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1439812 - Move noscript methods of nsIPlainTextEditor to TextEditor.

maxTextLength is unused from script, so I would like to move to TextEditor.
Also, there is no reason to keep setText on nsIPlainText.

Review commit: https://reviewboard.mozilla.org/r/221848/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221848/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8952611 [details]
Bug 1439812 - Move noscript methods of nsIPlainTextEditor to TextEditor.

https://reviewboard.mozilla.org/r/221848/#review227742

Assuming that neither c-c nor bluegriffon uses these methods from C++.

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8952611 [details]
Bug 1439812 - Move noscript methods of nsIPlainTextEditor to TextEditor.

https://reviewboard.mozilla.org/r/221848/#review227742

Yes, c-c and bluegriffon don't use maxTextLength

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/690c1b3c4880
Move noscript methods of nsIPlainTextEditor to TextEditor. r=masayuki

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/690c1b3c4880