1439831 - Enable ESLint rule mozilla/use-services for mobile/android

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement, P3)

Description

[Mark Banner (:standard8)]

As we've been doing elsewhere, this continues the work to replace .getService() with Services.jsm uses where possible and enable the mozilla/use-services rule, this has generally more easy to read code, will make the testing code more consistent with the rest of development and have perf advantages.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1439831 - Enable ESLint rule mozilla/use-services for mobile/android.

Review commit: https://reviewboard.mozilla.org/r/221892/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221892/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8952642 [details]
Bug 1439831 - Enable ESLint rule mozilla/use-services for mobile/android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221892/diff/1-2/

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8952642 [details]
Bug 1439831 - Enable ESLint rule mozilla/use-services for mobile/android.

https://reviewboard.mozilla.org/r/221892/#review230530

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8952642 [details]
Bug 1439831 - Enable ESLint rule mozilla/use-services for mobile/android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221892/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d73894a5fc4
Enable ESLint rule mozilla/use-services for mobile/android. r=nechen

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0d73894a5fc4