1439881 - Crash in nsNativeThemeGTK::DrawWidgetBackground

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Clemens Eisserer]

I experience this crash rather frequently on fedora 27, kde, 4k monitor with scaling=1.4 and the Adwaita GTK3 theme.

This bug was filed from the Socorro interface and is
report bp-4131e761-8916-4633-8a47-c89b10180221.
=============================================================

Top 10 frames of crashing thread:

0 libxul.so nsNativeThemeGTK::DrawWidgetBackground 
1 libxul.so nsDisplayThemedBackground::PaintInternal 
2 libxul.so mozilla::FrameLayerBuilder::PaintItems 
3 libxul.so mozilla::FrameLayerBuilder::DrawPaintedLayer 
4 libxul.so mozilla::layers::BasicPaintedLayer::PaintThebes 
5 libxul.so mozilla::layers::BasicLayerManager::PaintLayer 
6 libxul.so mozilla::layers::BasicLayerManager::PaintLayer 
7 libxul.so mozilla::layers::BasicLayerManager::EndTransactionInternal 
8 libxul.so nsDisplayList::PaintRoot 
9 libxul.so nsLayoutUtils::PaintFrame 

=============================================================

Comment 1

[Julien Cristau [:jcristau]]

According to crash-stats this started in nightly build-id 20180220220044, with 2 installs crashing multiple times.

Comment 2

[Julien Cristau [:jcristau]]

All of these are SIGFPE.  Martin, could any of your recent widget/gtk explain this?

Comment 3

[Martin Stránský [:stransky] (ni? me)]

(In reply to Julien Cristau [:jcristau] from comment #2)
> All of these are SIGFPE.  Martin, could any of your recent widget/gtk
> explain this?

Yes, it's possible that scaleFactor at nsNativeThemeGTK::DrawWidgetBackground() is 0 which may cause the divide error. May be a regression from Bug 1431337. I see that crash comes from child process which uses pupet widget implementation. Adding Jan.

Clements, what do you mean by "scaling=1.4"? Do you have set devPixelsPerPx at about:config or Gtk+ font scale for whole system?

Comment 4

[Clemens Eisserer]

> Clements, what do you mean by "scaling=1.4"? 
> Do you have set devPixelsPerPx at about:config or Gtk+ font scale for whole system?

I previously had devPixelsPerPx=1.4, but recentl I switched to devPixelsPerPx=-1 and have a GTK+ font scale of 1.4 system wide.
However, this change did not have any influence on the crash behaviour.

Comment 5

[Jan Horak [:jhorak]]

Attachment: Bug 1439881 - Avoid returning monitor scale 0;

Because of rounding errors there's a change that returned monitor scale
is 0. That would lead to SIGFPE because it's later used in division.

Review commit: https://reviewboard.mozilla.org/r/222324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222324/

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8953050 [details]
Bug 1439881 - Avoid returning monitor scale 0;

https://reviewboard.mozilla.org/r/222324/#review228224

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Hm, try looks strange:

[task 2018-02-22T14:21:47.149Z] 14:21:47    ERROR - GECKO(2904) | ==2999==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7f5a181f9a53 bp 0x7f5a1426e300 sp 0x7f5a1426e2e0 T2

Comment 8

[Martin Stránský [:stransky] (ni? me)]

(In reply to Martin Stránský [:stransky] from comment #7)
> Hm, try looks strange:
> 
> [task 2018-02-22T14:21:47.149Z] 14:21:47    ERROR - GECKO(2904) |
> ==2999==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc
> 0x7f5a181f9a53 bp 0x7f5a1426e300 sp 0x7f5a1426e2e0 T2

Seems to be Bug 1436383 not related to this one.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31c59ada523a
Avoid returning monitor scale 0; r=stransky

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/31c59ada523a

Comment 11

[Hiroyuki Ikezoe (:hiro)]

I am seeing lots of warning on console;

[Parent 4530, Main Thread] WARNING: Invalid monitor scale: -1: file /home/ikezoe/stylo/widget/gtk/nsNativeThemeGTK.cpp, line 85

They are very noisy.  Can we void spewing the message?

Comment 12

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #11)
> I am seeing lots of warning on console;
> 
> [Parent 4530, Main Thread] WARNING: Invalid monitor scale: -1: file
> /home/ikezoe/stylo/widget/gtk/nsNativeThemeGTK.cpp, line 85
> 
> They are very noisy.  Can we void spewing the message?

*avoid*

Comment 13

[Martin Stránský [:stransky] (ni? me)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #11)
> I am seeing lots of warning on console;
> 
> [Parent 4530, Main Thread] WARNING: Invalid monitor scale: -1: file
> /home/ikezoe/stylo/widget/gtk/nsNativeThemeGTK.cpp, line 85
> 
> They are very noisy.  Can we void spewing the message?

Follow up Bug 1441108.