Closed
Bug 1439906
Opened 6 years ago
Closed 6 years ago
Add automated test for "Bookmark folders can be cut/copied via context menu"
Categories
(Firefox :: Bookmarks & History, enhancement, P2)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: gechim, Assigned: gechim)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
18.75 KB,
patch
|
standard8
:
review-
|
Details | Diff | Splinter Review |
TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/4151 combined with TestRaild link: https://testrail.stage.mozaws.net/index.php?/cases/view/4152 1. Launch Firefox. 2. Enable the Bookmarks Toolbar. 3. Right - click any folder with bookmarks available and select Copy. 4. Right - click a folder that's different from the selected folder's parent and select Paste. 5. Repeat these steps using the Bookmarks Sidebar. 1. Firefox is successfully launched. 2. The Bookmarks Toolbar is enabled and displayed below the Location Bar. 3. The selected folder of bookmarks is successfully copied to clipboard. 4. The action is successful and no errors are thrown in the Browser Console for it. 5. Copying and pasting a folder with bookmarks is working from the Bookmarks Sidebar as well. Same steps are executed again but with Cut command instead of Copy.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → gechim
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8952708 -
Flags: review?(standard8)
Assignee | ||
Comment 2•6 years ago
|
||
Try Result : https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b588762b96a4aab13bf808521f1390d72e2d0dd
Comment 3•6 years ago
|
||
I don't think we need this test, at least not in the currently suggested form. We already have xpcshell-tests which test for copying folder trees, e.g. https://searchfox.org/mozilla-central/rev/9a8d3f8191b15cdca89a7ce044c7bea2dd0462dc/toolkit/components/places/tests/unit/test_async_transactions.js#1563 We also have various tests which run in mochitest for copy & pasting and check the results in some locations, e.g. https://searchfox.org/mozilla-central/rev/9a8d3f8191b15cdca89a7ce044c7bea2dd0462dc/browser/components/places/tests/browser/browser_paste_bookmarks.js I think at most, we need a simple test of a bookmark copy/paste to check that the menu items actually work, but even that is dubious given the other tests we've got, and the very small likelihood that we'd break the menu click to function call path.
Updated•6 years ago
|
Attachment #8952708 -
Flags: review?(standard8) → review-
Comment 4•6 years ago
|
||
Thank you for working on this, I'm just not sure the test is fully worth it.
Updated•6 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [fxsearch]
Assignee | ||
Comment 5•6 years ago
|
||
Hi Mark, Thank you for the review. Indeed ... it seems like this scenario is already covered. Can we mark this as duplicate or invalid in order to close it ? Thank you.
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(standard8)
Comment 6•6 years ago
|
||
Let's just mark it works for me. Thanks.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: needinfo?(standard8)
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•