1439964 - The image is wrongly displayed if the "View Image" option is used

Status: RESOLVED DUPLICATE of bug 1439444

(Firefox :: Screenshots, defect, P1)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: View Image.mp4

[Regression]:
- This issue is not reproducible with latest Firefox 58.0.0 release. Considering this I have performed a regression in order to find which bug introduced this. Here are the results:

Last good revision: 7faf85adc8988c19f9d5a1b396d129c84e6b28f9
First bad revision: d4aa33646f8bb62025644f240b71af17a854fcca
Pushlog: https://goo.gl/FifYqS

Looks like Bug 1432358 introduce this issue. 

[Affected versions]:
- Nightly 60.0a1
- Screenshots 29.0.0

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have a saved shot link (eg: https://screenshots.firefox.com/DxIJR78vZSciQGqW/www.wikipedia.org).

[Steps to reproduce]:
1. Start the browser and navigate to the saved shot link from prerequisites.
2. Right click on the image and choose the "View Image".
3. Observe the image's position and the background of the page. 

[Expected result]:
- The page has a dark grey background and the image is displayed in its center.

[Actual results]:
- The page has a white background and the image is displayed in the top right corner.

[Notes]:
- The issue is also reproducible if you simply click the image of saved shot.
- Attached a screen recording with the issue.

Comment 1

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I don't have access to bug 1432358 and I am not sure if the issue should be fixed on Screenshots or on the browser's side.
@Christoph can you please take a look at this issue?

Also, here are the browser console errors displayed after clicking the "View Image" option from context menu: https://goo.gl/ns1ihr

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Yes, this is caused by Bug 1432358. I'll take a look.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Is this something that can make it into 60?  Do we need a backout?

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Milan Sreckovic [:milan] from comment #3)
> Is this something that can make it into 60?  Do we need a backout?

Not sure if this is going to make it into 60. Please note that this problem only occurs if the page ships a strict CSP. We can not easily backout that change because it was a security fix. If people feel strongly that this gets fixed than I can try to prioritize.

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

Following the STRs from comment 0:
* Opening https://screenshots.firefox.com/DxIJR78vZSciQGqW/www.wikipedia.org
* right-click -> view image

I get the following errors in the console:
Content Security Policy: The page’s settings blocked the loading of a resource at resource://content-accessible/ImageDocument.css (“style-src”).  (unknown)
Content Security Policy: The page’s settings blocked the loading of a resource at resource://content-accessible/TopLevelImageDocument.css (“style-src”).  (unknown)
Content Security Policy: The page’s settings blocked the loading of a resource at chrome://global/skin/media/TopLevelImageDocument.css (“style-src”).  (unknown)

Applying the patch from Bug 1439444 the errors go away and the image appears as it should.

Once the patch within Bug 1439444 landed we should have someone verify again and then we can mark this bug as a duplicate of Bug 1439444.

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

Both me and Gijs verified [1] that Bug 1439444 fixed this problem here as well. Marking as a duplicate.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1439444#c19