Closed Bug 1440030 Opened 4 years ago Closed 4 years ago

CamelCase existing policies

Categories

(Firefox :: Enterprise Policies, enhancement)

Product:
Firefox
Component:
Enterprise Policies
Version:
60 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

Details

Attachments

(1 file)

Bug 1440030 - CamelCase existing policies to match industry standard.
59 bytes, text/x-review-board-request
mkaply
: review+
Details 
The first policies that landed, landed in the style lowercase_with_underscores. But the industry-standard for policies is to use CamelCase (that begins with a capital letter), so let's switch to that.
Comment on attachment 8952819 [details]
Bug 1440030 - CamelCase existing policies to match industry standard.

https://reviewboard.mozilla.org/r/222050/#review227946

I'm going to assume you ran all the tests :)
Attachment #8952819 - Flags: review?(mozilla) → review+
(running them now :P)

I'll land this once bug 1429148 gets merged to mozilla-central, otherwise this will cause a merge conflict in autoland.
All tests passed.

In this version I also camel-cased the internal objects ("allow" and "block") to be "Allow" and "Block"
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/38bf9bbc878b
CamelCase existing policies to match industry standard. r=mkaply
https://hg.mozilla.org/mozilla-central/rev/38bf9bbc878b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.