1440030 - CamelCase existing policies

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement)

Description

[:Felipe Gomes (needinfo for replies!)]

The first policies that landed, landed in the style lowercase_with_underscores. But the industry-standard for policies is to use CamelCase (that begins with a capital letter), so let's switch to that.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1440030 - CamelCase existing policies to match industry standard.

Review commit: https://reviewboard.mozilla.org/r/222050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222050/

Comment 2

[Mike Kaply [:mkaply] (PTO until Sept 14)]

Comment on attachment 8952819 [details]
Bug 1440030 - CamelCase existing policies to match industry standard.

https://reviewboard.mozilla.org/r/222050/#review227946

I'm going to assume you ran all the tests :)

Comment 3

[:Felipe Gomes (needinfo for replies!)]

(running them now :P)

I'll land this once bug 1429148 gets merged to mozilla-central, otherwise this will cause a merge conflict in autoland.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8952819 [details]
Bug 1440030 - CamelCase existing policies to match industry standard.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222050/diff/1-2/

Comment 5

[:Felipe Gomes (needinfo for replies!)]

All tests passed.

In this version I also camel-cased the internal objects ("allow" and "block") to be "Allow" and "Block"

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/38bf9bbc878b
CamelCase existing policies to match industry standard. r=mkaply

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/38bf9bbc878b