Closed Bug 1440205 Opened 4 years ago Closed 4 years ago

Print bad canary info in hexadecimal

Categories

(Core :: XPCOM, enhancement)

Product:
Core
Component:
XPCOM
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: pbone, Assigned: pbone)

Details

Attachments

(1 file)

Bug 1440205 - Print the nsStringBuffer bad canary value in hex
1.18 KB, patch
jonco
: review+
Details | Diff | Splinter Review 
No description provided.
Hi Jonco,

Hex values make more sense here and will help the next person to look at one of these crashes.

I'm not sure if you're the best person to review this, feel free to refer it if you're not.

Thanks.
Assignee: nobody → pbone
Status: NEW → ASSIGNED
Attachment #8952954 - Flags: review?(jcoppeard)
Attachment #8952954 - Flags: review?(jcoppeard) → review+
(In reply to Paul Bone [:pbone] from comment #1)
I'm not an XPCOM peer but I think this is OK for a simple change like this.
Pushed by pbone@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2627872300c
Print the nsStringBuffer bad canary value in hex r=jonco
https://hg.mozilla.org/mozilla-central/rev/d2627872300c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.