1440308 - Add Qwant to the French version of Desktop Firefox

Status: VERIFIED FIXED

(Firefox :: Search, enhancement)

Description

[Mike Kaply [:mkaply]]

We just finalized the contract and got search codes to include Qwant in the French version only of Firefox.

Similar to Ecosia.

This will be a very straightforward change.

[Tracking Requested - why for this release]: Partner deal.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1440308 - Add Qwant to French Firefox.

Review commit: https://reviewboard.mozilla.org/r/222500/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222500/

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8953213 [details]
Bug 1440308 - Add Qwant to French Firefox.

https://reviewboard.mozilla.org/r/222500/#review228454

::: browser/locales/searchplugins/qwant.xml:9
(Diff revision 1)
> +
> +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>Qwant</ShortName>
> +<Description>Search Qwant</Description>
> +<InputEncoding>UTF-8</InputEncoding>
> +<Image height="16" width="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAn1JREFUeNqMU99P01AYPbdb221so2W4hDFCFYwRNJToC8bo+Ad0Jv4BIya+wh59MhjfefCNxGwmvjN9I5qAMT74YOhUMCRiQAIui2VlrPvd1ntLIKAQ/JIvvff0O+f29PsuwQnRLF9Pwh9Q6fI2TcNo8fmmzeXiwTfa37Xk6Mb+MZiwPcg4Hii23w+IAhrEBxN+WI5bukgzfVToUKD9Xkk5IU+mxhFULALdAnSG+wTwsgRJ5KF7e/HBGjUa4MefRia1QwHrrZIAh4Va2QtDBEyBGKaI6YoPWl3uhMPzd2lZKl+XpM3gLXSKAYPuR6nIunfftJOBxUEo8vD2tjTBcsYv3fxuHHG3OP9z7MXKXt/cl9I35UbfZalFuh9TfIJYc/0qPX2JlATQNHYGGucjd46RDyOcea6ibS+JUQ88ykUGyRxaTpKZJbs8A7KnkVmUJx5oxKjnGrp9AKkcN+v0c8/ocpXmLl7hrGjbeVJpHuwSXhTcBgIFmkWC/wqzhUAZ6OmKUffAhgvWqcAmUc8kO2TEqQqIcd0IEt8iE3D72dyoABVMOsND0mnc8KNZlZKT4UgUHXKYQRpHvm7myr9K6/ryNsqFgkLBmZNEKJm9c9sdHYi7P3x+qNdw58DUK2n6mDP1HXg65NRa6GHi07A4TbF1dsq15SlD4K/MNAMRtR2IonROQM203jEus4AYkGNDsYc4PutjaFr8/mnAAmsVqxExOBGqypq/aqOoi9iqhTKxj06KO/hEKpJdxf17v81uo7i2jYZZP2Zh60mUzce4r2ple+wW4jIgBaD907fXmGL+k+wqSz0RpaMrlKYWjl3jCy/3ZnwjwfzKVZL9I8AAWH/wmyfGUzkAAAAASUVORK5CYII=</Image>

We should not be using a 16px PNG on desktop. They have a suitable .ico, it can probably benefit from some optimization.
https://www.qwant.com/favicon.ico?1519321103707

::: browser/locales/searchplugins/qwant.xml:14
(Diff revision 1)
> +<Image height="16" width="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAn1JREFUeNqMU99P01AYPbdb221so2W4hDFCFYwRNJToC8bo+Ad0Jv4BIya+wh59MhjfefCNxGwmvjN9I5qAMT74YOhUMCRiQAIui2VlrPvd1ntLIKAQ/JIvvff0O+f29PsuwQnRLF9Pwh9Q6fI2TcNo8fmmzeXiwTfa37Xk6Mb+MZiwPcg4Hii23w+IAhrEBxN+WI5bukgzfVToUKD9Xkk5IU+mxhFULALdAnSG+wTwsgRJ5KF7e/HBGjUa4MefRia1QwHrrZIAh4Va2QtDBEyBGKaI6YoPWl3uhMPzd2lZKl+XpM3gLXSKAYPuR6nIunfftJOBxUEo8vD2tjTBcsYv3fxuHHG3OP9z7MXKXt/cl9I35UbfZalFuh9TfIJYc/0qPX2JlATQNHYGGucjd46RDyOcea6ibS+JUQ88ykUGyRxaTpKZJbs8A7KnkVmUJx5oxKjnGrp9AKkcN+v0c8/ocpXmLl7hrGjbeVJpHuwSXhTcBgIFmkWC/wqzhUAZ6OmKUffAhgvWqcAmUc8kO2TEqQqIcd0IEt8iE3D72dyoABVMOsND0mnc8KNZlZKT4UgUHXKYQRpHvm7myr9K6/ryNsqFgkLBmZNEKJm9c9sdHYi7P3x+qNdw58DUK2n6mDP1HXg65NRa6GHi07A4TbF1dsq15SlD4K/MNAMRtR2IonROQM203jEus4AYkGNDsYc4PutjaFr8/mnAAmsVqxExOBGqypq/aqOoi9iqhTKxj06KO/hEKpJdxf17v81uo7i2jYZZP2Zh60mUzce4r2ple+wW4jIgBaD907fXmGL+k+wqSz0RpaMrlKYWjl3jCy/3ZnwjwfzKVZL9I8AAWH/wmyfGUzkAAAAASUVORK5CYII=</Image>
> +<Url type="application/x-suggestions+json" method="GET" template="https://api.qwant.com/api/suggest/">
> +  <Param name="client" value="opensearch"/>
> +  <Param name="q" value="{searchTerms}"/>
> +</Url>
> +<Url type="text/html" method="GET" template="https://www.qwant.com/">

Add `rel="searchform"`

::: browser/locales/searchplugins/qwant.xml:18
(Diff revision 1)
> +</Url>
> +<Url type="text/html" method="GET" template="https://www.qwant.com/">
> +  <Param name="client" value="brz-moz"/>
> +  <Param name="q" value="{searchTerms}"/>
> +</Url>
> +<SearchForm>https://www.qwant.com/</SearchForm>

Remove this

Comment 3

[Francesco Lodolo [:flod]]

Attachment: qwant.ico

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 8953213 [details]
Bug 1440308 - Add Qwant to French Firefox.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222500/diff/1-2/

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 8953213 [details]
Bug 1440308 - Add Qwant to French Firefox.

https://reviewboard.mozilla.org/r/222500/#review228542

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77b6661a3618
Add Qwant to French Firefox. r=flod

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/77b6661a3618

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 9

[Mike Kaply [:mkaply]]

Comment on attachment 8953213 [details]
Bug 1440308 - Add Qwant to French Firefox.

Approval Request Comment
[Feature/Bug causing the regression]: Add new search engine for French build
[User impact if declined]: No Qwant search
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Install French Firefox. Verify new engine (rainbow Q icon). Set engine as default and verify there are search suggestions.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: just adds engine to the existing list.
[String changes made/needed]:

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8953213 [details]
Bug 1440308 - Add Qwant to French Firefox.

We should verify this, but let's go ahead and uplift for today's beta 13 build.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0e8105f2fe55

Comment 12

[Ciprian Georgiu, Desktop QA]

I've managed to verify that Qwant search engine works as expected (per comment 9), on Beta 59.0b13 (20180226180053) and latest Nightly 60.0a1 (2017-02-27) using the "fr" build. The tests were done on the following OSes: Windows 10 x64, macOS 10.13 and Ubuntu 16.04 x64.

Marking this as verified fixed.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Release note for 59: Added the Qwant search engine as an option for French users

If you have a suggested change for the wording please n-i me or let me know over IRC.

Comment 14

[Mike Kaply [:mkaply]]

Perfect.